-
Notifications
You must be signed in to change notification settings - Fork 749
Add new event for finalizing resource annotations and use to configure installer certificate trust #13200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danegsta
wants to merge
12
commits into
dotnet:main
Choose a base branch
from
danegsta:danegsta/installerCertConfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new event for finalizing resource annotations and use to configure installer certificate trust #13200
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f679c22
Add new event for finalizing resource annotations
danegsta c680552
Update suppression file for new eventing method
danegsta b939863
Properly update the suppression file
danegsta a659202
Switch to using annotation instead of event
danegsta cf989d0
Merge remote-tracking branch 'upstream/main' into danegsta/installerC…
danegsta 8f8ea2d
Update comments and indenting
danegsta b15acfc
Add test coverage
danegsta 63c4f9d
Update src/Aspire.Hosting/ApplicationModel/CertificateAuthorityCollec…
danegsta f3b19fe
Merge remote-tracking branch 'upstream/main' into danegsta/installerC…
danegsta 1e8b3a4
Make API experimental
danegsta b0e1a7d
Add one more pragma warning suppression
danegsta 8259af6
Add one more pragma warning suppression
danegsta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/Aspire.Hosting/ApplicationModel/FinalizeResourceConfigurationCallbackAnnotation.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
||
| /// <summary> | ||
| /// Annotation to register a callback to be invoked during resource finalization. Callbacks are executed in reverse order | ||
| /// of their registration immediately after the BeforeStartEvent is complete. | ||
| /// </summary> | ||
danegsta marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public sealed class FinalizeResourceConfigurationCallbackAnnotation : IResourceAnnotation | ||
| { | ||
| /// <summary> | ||
| /// The callback to be invoked during resource finalization. | ||
| /// </summary> | ||
| public required Func<FinalizeResourceConfigurationCallbackAnnotationContext, Task> Callback { get; init; } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Context for a finalize resource configuration callback annotation. | ||
| /// </summary> | ||
danegsta marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public sealed class FinalizeResourceConfigurationCallbackAnnotationContext | ||
| { | ||
| /// <summary> | ||
| /// The resource associated with the callback. | ||
| /// </summary> | ||
| public required IResource Resource { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The execution context for the callback. | ||
| /// </summary> | ||
| public required DistributedApplicationExecutionContext ExecutionContext { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The cancellation token for the callback. | ||
| /// </summary> | ||
| public required CancellationToken CancellationToken { get; init; } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.