diff --git a/src/Aspire.Hosting.Docker/EnvFile.cs b/src/Aspire.Hosting.Docker/EnvFile.cs index c36f07d5c27..23dcde95098 100644 --- a/src/Aspire.Hosting.Docker/EnvFile.cs +++ b/src/Aspire.Hosting.Docker/EnvFile.cs @@ -43,19 +43,12 @@ public static EnvFile Load(string path) public void Add(string key, string? value, string? comment, bool onlyIfMissing = true) { - if (_entries.ContainsKey(key)) + if (_entries.ContainsKey(key) && onlyIfMissing) { - if (onlyIfMissing) - { - return; - } - - _entries[key] = new EnvEntry(key, value, comment); - } - else - { - _entries[key] = new EnvEntry(key, value, comment); + return; } + + _entries[key] = new EnvEntry(key, value, comment); } private static bool TryParseKeyValue(string line, out string key, out string? value) diff --git a/tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs b/tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs index b9694915504..8f12bd103dd 100644 --- a/tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs +++ b/tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs @@ -172,8 +172,6 @@ public void DockerComposeDoesNotHandleImageBuildingDuringPublish() builder.AddDockerComposeEnvironment("docker-compose"); - builder.Services.AddSingleton(); - builder.AddContainer("resource", "mcr.microsoft.com/dotnet/aspnet:8.0") .WithEnvironment("ASPNETCORE_ENVIRONMENT", "Development") .WithHttpEndpoint(env: "HTTP_PORT");