Simplify CreateTempFile API to take no parameters

Co-authored-by: davidfowl <[email protected]>

Author: Copilot

IMPLEMENTATION_STATUS.md

@@ -5,10 +5,10 @@ This document tracks the implementation of IFileSystemService across the Aspire
 ## Completed Tasks
 
 ### Core API
-- ✅ Created `src/Aspire.Hosting/Utils/IFileSystemService.cs` with adjusted API
-  - Renamed `GetTempFileName` → `CreateTempFile(string? extension = null)`
-  - Added overload `CreateTempFile(string prefix, string fileName)`
-  - Improved XML documentation with clarity about parent directory disposal
+- ✅ Created `src/Aspire.Hosting/Utils/IFileSystemService.cs` with simplified API
+  - Single `CreateTempFile()` method with no parameters for creating temp files
+  - `CreateTempSubdirectory(string? prefix = null)` for creating temp directories
+  - Simplified XML documentation
 - ✅ Created `src/Aspire.Hosting/Utils/FileSystemService.cs` implementation
 - ✅ Updated `src/Aspire.Hosting/IDistributedApplicationBuilder.cs`
   - Added FileSystemService property
@@ -125,20 +125,17 @@ var directoryService = builder.ApplicationBuilder.FileSystemService;
 ### 3. Replace temp file/directory APIs
 ```csharp
 // OLD: Path.GetTempFileName()
-// NEW: directoryService.TempDirectory.CreateTempFile("prefix", "filename.ext").Path
+// NEW: directoryService.TempDirectory.CreateTempFile().Path
 
 // OLD: Directory.CreateTempSubdirectory("prefix")
 // NEW: directoryService.TempDirectory.CreateTempSubdirectory("prefix").Path
-
-// For random temp file with specific extension:
-// directoryService.TempDirectory.CreateTempFile(".json").Path
 ```
 
 ## Key Adjustments from Original PR #13244
 
-1. ✅ **Renamed API**: `GetTempFileName(extension?)` → `CreateTempFile(extension?)`
+1. ✅ **Simplified API**: `CreateTempFile()` with no parameters - simple temp file creation
 2. ✅ **Removed Documentation**: Removed references to ASPIRE_TEMP_FOLDER and Aspire:TempDirectory configuration
-3. ✅ **Improved Docs**: Added clarity about parent directory disposal in TempFile XML docs
+3. ✅ **Simplified Implementation**: Removed complex overloads and parent directory deletion logic
 4. ⏳ **Line Numbers**: Need to fix line numbers in docs/temp-folder-inventory.md tables
 5. ⏳ **Tests**: Need to create comprehensive FileSystemServiceTests.cs
 
@@ -156,6 +153,6 @@ Before finalizing, ensure:
 ## Notes
 
 - The pattern of extracting `.Path` and not disposing is **intentional** - many temp files/dirs persist for app lifetime
-- When using `CreateTempFile(prefix, fileName)`, the parent directory is auto-deleted on Dispose
-- When using `CreateTempFile(extension)`, only the file is deleted (no parent dir cleanup)
+- `CreateTempFile()` creates a simple temp file, caller is responsible for cleanup if needed
+- `CreateTempSubdirectory(prefix)` creates a temp directory that can be disposed to clean up
 - All APIs are marked `[Experimental("ASPIREFILESYSTEM001")]`

src/Aspire.Hosting/ApplicationModel/AspireStore.cs

@@ -49,7 +49,7 @@ public string GetFileNameWithContent(string filenameTemplate, Stream contentStre
         filenameTemplate = Path.GetFileName(filenameTemplate);
 
         // Create a temporary file to write the content to.
-        var tempFileName = _directoryService.TempDirectory.CreateTempFile("aspire-store", "content.tmp").Path;
+        var tempFileName = _directoryService.TempDirectory.CreateTempFile().Path;
 
         // Fast, non-cryptographic hash.
         var hash = new XxHash3();

src/Aspire.Hosting/Utils/FileSystemService.cs

@@ -28,25 +28,10 @@ public TempDirectory CreateTempSubdirectory(string? prefix = null)
         }
 
         /// <inheritdoc/>
-        public TempFile CreateTempFile(string? extension = null)
+        public TempFile CreateTempFile()
         {
             var tempFile = Path.GetTempFileName();
-            if (extension is not null)
-            {
-                var newPath = Path.ChangeExtension(tempFile, extension);
-                File.Move(tempFile, newPath);
-                return new DefaultTempFile(newPath, deleteParentDirectory: false);
-            }
-            return new DefaultTempFile(tempFile, deleteParentDirectory: false);
-        }
-
-        /// <inheritdoc/>
-        public TempFile CreateTempFile(string prefix, string fileName)
-        {
-            var tempDir = Directory.CreateTempSubdirectory(prefix).FullName;
-            var filePath = Path.Combine(tempDir, fileName);
-            File.Create(filePath).Dispose();
-            return new DefaultTempFile(filePath, deleteParentDirectory: true);
+            return new DefaultTempFile(tempFile);
         }
     }
 
@@ -86,12 +71,10 @@ public override void Dispose()
     private sealed class DefaultTempFile : TempFile
     {
         private readonly string _path;
-        private readonly bool _deleteParentDirectory;
 
-        public DefaultTempFile(string path, bool deleteParentDirectory)
+        public DefaultTempFile(string path)
         {
             _path = path;
-            _deleteParentDirectory = deleteParentDirectory;
         }
 
         public override string Path => _path;
@@ -104,15 +87,6 @@ public override void Dispose()
                 {
                     File.Delete(_path);
                 }
-
-                if (_deleteParentDirectory)
-                {
-                    var parentDir = System.IO.Path.GetDirectoryName(_path);
-                    if (parentDir is not null && Directory.Exists(parentDir))
-                    {
-                        Directory.Delete(parentDir, recursive: true);
-                    }
-                }
             }
             catch
             {

src/Aspire.Hosting/Utils/IFileSystemService.cs

@@ -52,33 +52,17 @@ public interface ITempFileSystemService
     /// <summary>
     /// Creates a new temporary file and returns it.
     /// </summary>
-    /// <param name="extension">Optional file extension including the dot (e.g., ".txt", ".json"). If null, uses the default .tmp extension.</param>
     /// <returns>A <see cref="TempFile"/> representing the created temporary file. Dispose to delete.</returns>
     /// <remarks>
     /// <para>
-    /// This method creates a new temporary file using <see cref="Path.GetTempFileName"/>
-    /// and optionally renames it with the specified extension. Dispose the returned object to delete the file.
+    /// This method creates a new temporary file using <see cref="Path.GetTempFileName"/>.
+    /// Dispose the returned object to delete the file.
     /// </para>
     /// <para>
     /// Use this instead of calling <see cref="Path.GetTempFileName"/> directly.
     /// </para>
     /// </remarks>
-    TempFile CreateTempFile(string? extension = null);
-
-    /// <summary>
-    /// Creates a new temporary file with the specified name in a temporary directory.
-    /// </summary>
-    /// <param name="prefix">Prefix for the temporary directory name.</param>
-    /// <param name="fileName">The name for the temporary file (e.g., "config.json", "script.php").</param>
-    /// <returns>A <see cref="TempFile"/> representing the created temporary file. Dispose to delete the file and its parent directory.</returns>
-    /// <remarks>
-    /// <para>
-    /// This method creates a temporary subdirectory with the given prefix and places a file with the specified name inside it.
-    /// This is useful when the filename matters (e.g., for scripts that check their own filename).
-    /// Dispose the returned object to delete the file and its parent directory.
-    /// </para>
-    /// </remarks>
-    TempFile CreateTempFile(string prefix, string fileName);
+    TempFile CreateTempFile();
 }
 
 /// <summary>
@@ -110,8 +94,7 @@ public abstract class TempFile : IDisposable
     public abstract string Path { get; }
 
     /// <summary>
-    /// Deletes the temporary file. When created with a specific file name in a temporary directory,
-    /// also deletes the parent directory.
+    /// Deletes the temporary file.
     /// </summary>
     public abstract void Dispose();
 }