Skip to content

Commit 15212ad

Browse files
authored
Ignore case on FormatDateTime_WithMilliseconds_NewZealandCulture due to macos formatting difference (#9316)
1 parent b1c3c38 commit 15212ad

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tests/Aspire.Dashboard.Tests/FormatHelpersTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.Globalization;
55
using Aspire.Dashboard.Model;
66
using Aspire.Dashboard.Utils;
7-
using Aspire.TestUtilities;
87
using Microsoft.Extensions.Logging.Abstractions;
98
using Xunit;
109

@@ -76,11 +75,11 @@ public void FormatDateTime_WithMilliseconds_FinnishCulture(string expected, Mill
7675
[InlineData("15/06/2009 1:45:30.1234567 pm", MillisecondsDisplay.Full, "2009-06-15T13:45:30.1234567Z")]
7776
[InlineData("15/06/2009 1:45:30 pm", MillisecondsDisplay.None, "2009-06-15T13:45:30.0000000Z")]
7877
[InlineData("15/06/2009 1:45:30 pm", MillisecondsDisplay.None, "2009-06-15T13:45:30.1234567Z")]
79-
[ActiveIssue("https://github.com/dotnet/aspire/issues/9151", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOS))]
8078
public void FormatDateTime_WithMilliseconds_NewZealandCulture(string expected, MillisecondsDisplay includeMilliseconds, string value)
8179
{
8280
var date = GetLocalDateTime(value);
83-
Assert.Equal(expected, FormatHelpers.FormatDateTime(CreateTimeProvider(), date, includeMilliseconds, cultureInfo: CultureInfo.GetCultureInfo("en-NZ")), ignoreWhiteSpaceDifferences: true);
81+
// macOS formats with uppercase AM/PM, so ignore case
82+
Assert.Equal(expected, FormatHelpers.FormatDateTime(CreateTimeProvider(), date, includeMilliseconds, cultureInfo: CultureInfo.GetCultureInfo("en-NZ")), ignoreWhiteSpaceDifferences: true, ignoreCase: true);
8483
}
8584

8685
private static DateTime GetLocalDateTime(string value)

0 commit comments

Comments
 (0)