Skip to content

Commit 12957de

Browse files
committed
Update Pomelo to v8.0.1. Fixes #2690
This reflects connection string validation changes from PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1819.
1 parent 0e6e271 commit 12957de

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
<PackageVersion Include="Polly" Version="8.3.0" />
100100
<PackageVersion Include="Polly.Core" Version="8.3.0" />
101101
<PackageVersion Include="Polly.Extensions" Version="8.3.0" />
102-
<PackageVersion Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.0-beta.2" />
102+
<PackageVersion Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.1" />
103103
<PackageVersion Include="RabbitMQ.Client" Version="6.8.1" />
104104
<PackageVersion Include="StackExchange.Redis" Version="2.7.27" />
105105
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />

src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/AspireEFMySqlExtensions.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,13 @@ public static partial class AspireEFMySqlExtensions
6262

6363
if (builder.Configuration.GetConnectionString(connectionName) is string connectionString)
6464
{
65-
settings.ConnectionString = connectionString;
65+
// apply the settings that Pomelo EF Core requires
66+
var connectionStringBuilder = new MySqlConnectionStringBuilder(connectionString)
67+
{
68+
AllowUserVariables = true,
69+
UseAffectedRows = false,
70+
};
71+
settings.ConnectionString = connectionStringBuilder.ConnectionString;
6672
}
6773

6874
configureSettings?.Invoke(settings);

tests/Aspire.Pomelo.EntityFrameworkCore.MySql.Tests/AspireEFMySqlExtensionsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void ConnectionStringCanBeSetInCode()
4141
var builder = Host.CreateEmptyApplicationBuilder(null);
4242
builder.Configuration.AddInMemoryCollection([
4343
new KeyValuePair<string, string?>("Aspire:Pomelo:EntityFrameworkCore:MySql:ServerVersion", "8.2.0-mysql"),
44-
new KeyValuePair<string, string?>("ConnectionStrings:mysql", "unused")
44+
new KeyValuePair<string, string?>("ConnectionStrings:mysql", "")
4545
]);
4646

4747
builder.AddMySqlDbContext<TestDbContext>("mysql", settings => settings.ConnectionString = ConnectionString);

0 commit comments

Comments
 (0)