From ff2745a720637a60113b65015d2a40c32516a764 Mon Sep 17 00:00:00 2001
From: Jonathan Pryor <jonpryor@vt.edu>
Date: Wed, 17 Aug 2016 19:24:30 -0400
Subject: [PATCH] [Xamarin.Android.Build.Tasks] Cleanup @(ProjectReference)

Partially reverts commits 8a255345, daddcdf3.

A `@(ProjectReference)` with
`%(ProjectReference.ReferenceOutputAssembly)` set to False is useful
to control MSBuild project dependencies, to ensure that a particular
project is built before other projects.

`Xamarin.Android.Build.Tasks.csproj` contains two of these of
questionable value:

1. `Xamarin.Android.Tools.BootstrapTasks.csproj` (8a255345) is
    referenced, and I don't recall *why* it's referenced.
    Additionally, removing this reference doesn't break anything.

2. `class-parse.csproj` (daddcdf3) is referenced, but the logic in the
    commit message doesn't make sense, given that
    `Xamarin.Android.Build.Tasks.dll` doesn't invoke
    `class-parse.exe`, it instead uses
    `Xamarin.Android.Tools.Bytecode.dll`, which is referenced
    normally.
    I thus don't understand why the `class-parse.csproj` reference is
    currently required.

Remove these two project references.
---
 .../Xamarin.Android.Build.Tasks.csproj             | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj b/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
index 17a41f1ff08..0d4ea42e08a 100644
--- a/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
+++ b/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
@@ -620,21 +620,15 @@
       <Project>{B17475BC-45A2-47A3-B8FC-62F3A0959EE0}</Project>
       <Name>Xamarin.Android.Tools.Bytecode</Name>
     </ProjectReference>
+    <!--
+      Mono.Android.csproj needs to be built first because this project
+      references files *generated* and contained within the Mono.Android project.
+      -->
     <ProjectReference Include="..\..\src\Mono.Android\Mono.Android.csproj">
       <Project>{66CF299A-CE95-4131-BCD8-DB66E30C4BF7}</Project>
       <Name>Mono.Android</Name>
       <ReferenceOutputAssembly>False</ReferenceOutputAssembly>
     </ProjectReference>
-    <ProjectReference Include="..\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks.csproj">
-      <Project>{E8492EFB-D14A-4F32-AA28-88848322ECEA}</Project>
-      <Name>Xamarin.Android.Tools.BootstrapTasks</Name>
-      <ReferenceOutputAssembly>False</ReferenceOutputAssembly>
-    </ProjectReference>
-    <ProjectReference Include="$(JavaInteropFullPath)\tools\class-parse\class-parse.csproj">
-      <Project>{38C762AB-8FD1-44DE-9855-26AAE7129DC3}</Project>
-      <Name>class-parse</Name>
-      <ReferenceOutputAssembly>False</ReferenceOutputAssembly>
-    </ProjectReference>
     <ProjectReference Include="$(LibZipSharpSourceFullPath)\libZipSharp.csproj">
       <Project>{E248B2CA-303B-4645-ADDC-9D4459D550FD}</Project>
       <Name>libZipSharp</Name>