Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recording custom AOT profiles #7722

Open
Eilon opened this issue Jan 20, 2023 · 8 comments · May be fixed by #9267
Open

Support recording custom AOT profiles #7722

Eilon opened this issue Jan 20, 2023 · 8 comments · May be fixed by #9267
Assignees
Labels
Area: Mono Runtime Mono-related issues: BCL bugs, AOT issues, etc. enhancement Proposed change to current functionality.
Milestone

Comments

@Eilon
Copy link
Member

Eilon commented Jan 20, 2023


Issue moved from dotnet/maui#10237


From @sake402 on Wednesday, September 21, 2022 12:51:20 PM

Description

With a maui application dotnet build -t:BuildAndStartAotProfiling returns an error

Steps to Reproduce

dotnet add package Mono.AotProfiler.Android
dotnet build -t:BuildAndStartAotProfiling

Produces error

 error MSB4057: The target "BuildAndStartAotProfiling" does not exist in the project.

Link to public reproduction project repository

None

Version with bug

6.0.400

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 21

Did you find any workaround?

No response

Relevant log output

No response

@Eilon
Copy link
Member Author

Eilon commented Jan 20, 2023


Issue moved from dotnet/maui#10237

  • Please respond to @msftbot[bot].

From @msftbot[bot] on Wednesday, September 21, 2022 6:14:59 PM

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost ghost added the needs-triage Issues that need to be assigned. label Jan 20, 2023
@jpobst jpobst added the Area: Mono Runtime Mono-related issues: BCL bugs, AOT issues, etc. label Jan 23, 2023
@jonathanpeppers
Copy link
Member

Recording custom profiles is not yet fully supported in .NET 6 and 7. I have an experimental package to enable this at:

https://github.com/jonathanpeppers/Mono.Profiler.Android

We began the process of replacing libmono-profiler-aot.so with new .NET features:

It was not ready in time for .NET 7, but we may be able to revisit in .NET 8.

@jonathanpeppers jonathanpeppers added this to the .NET 8 milestone Jan 23, 2023
@jonathanpeppers jonathanpeppers changed the title Unable to record custom aot profile. [.NET 8] support recording custom aot profiles Jan 23, 2023
@jonathanpeppers jonathanpeppers added enhancement Proposed change to current functionality. and removed needs-triage Issues that need to be assigned. labels Jan 23, 2023
@jonpryor jonpryor modified the milestones: .NET 8, .NET 9 Planning Jul 24, 2023
@jpobst jpobst changed the title [.NET 8] support recording custom aot profiles Support recording custom AOT profiles Nov 15, 2023
@MitchBomcanhao
Copy link

any news on this front?

@jonathanpeppers
Copy link
Member

This lists the blockers:

I think the main issue, is dotnet-pgo is not distributed on NuGet.org. So waiting from the .NET teamt to see how that could be released where we can depend on it.

@themronion
Copy link

@jonathanpeppers but i successfully managed to record a profile using that experimental nuget just by specifying the android TF. That's exactly what the OP was missing in order for it to work. Or we shouldn't use that package anymore and wait?

@jonathanpeppers
Copy link
Member

@themronion you can use the experimental package, it's what we still use for the Android and MAUI workloads:

https://github.com/dotnet/maui/blob/0e61f5ecc51c65d8fa0bbfce89e8c5774d0e417f/src/ProfiledAot/src/Directory.Build.targets#L10

@crui3er
Copy link

crui3er commented Apr 10, 2024

@jonathanpeppers Am I correct that using mibc profiles is not yet possible in MAUI .NET8 or there is any way to benefit from using them?

@jonathanpeppers
Copy link
Member

The questions in using .mibc are listed here:

It might be something that comes in .NET 9, but the only benefit being it's "more supported" than the old Mono format.

@mdh1418 mdh1418 linked a pull request Aug 30, 2024 that will close this issue
@jonathanpeppers jonathanpeppers modified the milestones: .NET 9, .NET 10 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Mono Runtime Mono-related issues: BCL bugs, AOT issues, etc. enhancement Proposed change to current functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants