Skip to content

Commit 28e1f93

Browse files
jonathanpeppersjonpryor
jonathanpeppers
authored and
jonpryor
committed
[Xamarin.Android.Build.Tasks] not so many log messages! (#2952)
We used to have the pattern of including log messages at the beginning of `Execute()` in MSBuild tasks: Log.LogDebugMessage ("MyMSBuildTask Task"); Log.LogDebugMessage (" FooProperty: {0}", FooProperty); Log.LogDebugTaskItems (" BarItems: ", BarItems); This was mostly here to improve diagnostic log output from XBuild, which we no longer support. MSBuild properly logs any input properties on MSBuild tasks, so we can remove a lot of code! There were a couple places I could go a step further: * `<AndroidCreateDebugKey/>` and `<AndroidZipAlign/>` I could remove the entire `Execute()` method. * `<JavaCompileToolTask/>` had an `OnLogStarted` method I could remove. `<Javac/>` also was overriding this method. I thought this might have *some* impact on build times, since logging and `string.Format()` takes some time (it's not free!). A build of the Xamarin.Forms app in this repo: # Before Time Elapsed 00:00:25.66 Time Elapsed 00:00:25.36 Time Elapsed 00:00:25.67 # After Time Elapsed 00:00:24.58 Time Elapsed 00:00:23.98 Time Elapsed 00:00:24.98 The overall build times vary quite a bit. So if I took a conservative estimate it seems the initial build is 500ms better? A more revealing difference, I think, is the size of these binlog files: # fresh build 746947 before.first.binlog 740797 after.first.binlog # build with no changes 827913 before.second.binlog 825665 after.second.binlog # build with xaml change 848821 before.third.binlog 844365 after.third.binlog These files are compressed, so if they are 2K-6K smaller that was a lot of log messages...
1 parent 51c8fc6 commit 28e1f93

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+0
-287
lines changed

‎src/Xamarin.Android.Build.Tasks/Tasks/Aapt.cs

-19
Original file line numberDiff line numberDiff line change
@@ -211,25 +211,6 @@ void ProcessManifest (ITaskItem manifestFile)
211211

212212
public override bool Execute ()
213213
{
214-
Log.LogDebugMessage ("Aapt Task");
215-
Log.LogDebugMessage (" AssetDirectory: {0}", AssetDirectory);
216-
Log.LogDebugTaskItems (" ManifestFiles: ", ManifestFiles);
217-
Log.LogDebugMessage (" ResourceDirectory: {0}", ResourceDirectory);
218-
Log.LogDebugMessage (" JavaDesignerOutputDirectory: {0}", JavaDesignerOutputDirectory);
219-
Log.LogDebugMessage (" PackageName: {0}", PackageName);
220-
Log.LogDebugMessage (" UncompressedFileExtensions: {0}", UncompressedFileExtensions);
221-
Log.LogDebugMessage (" ExtraPackages: {0}", ExtraPackages);
222-
Log.LogDebugTaskItems (" AdditionalResourceDirectories: ", AdditionalResourceDirectories);
223-
Log.LogDebugTaskItems (" AdditionalAndroidResourcePaths: ", AdditionalAndroidResourcePaths);
224-
Log.LogDebugTaskItems (" LibraryProjectJars: ", LibraryProjectJars);
225-
Log.LogDebugMessage (" ExtraArgs: {0}", ExtraArgs);
226-
Log.LogDebugMessage (" CreatePackagePerAbi: {0}", CreatePackagePerAbi);
227-
Log.LogDebugMessage (" ResourceNameCaseMap: {0}", ResourceNameCaseMap);
228-
Log.LogDebugMessage (" VersionCodePattern: {0}", VersionCodePattern);
229-
Log.LogDebugMessage (" VersionCodeProperties: {0}", VersionCodeProperties);
230-
if (CreatePackagePerAbi)
231-
Log.LogDebugMessage (" SupportedAbis: {0}", SupportedAbis);
232-
233214
resourceDirectory = ResourceDirectory.TrimEnd ('\\');
234215
if (!Path.IsPathRooted (resourceDirectory))
235216
resourceDirectory = Path.Combine (WorkingDirectory, resourceDirectory);

‎src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Compile.cs

-5
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ public class Aapt2Compile : Aapt2 {
3030

3131
public override bool Execute ()
3232
{
33-
Log.LogDebugMessage ("Aapt2Compile Task");
34-
Log.LogDebugMessage (" ResourceNameCaseMap: {0}", ResourceNameCaseMap);
35-
Log.LogDebugMessage (" ResourceSymbolsTextFile: {0}", ResourceSymbolsTextFile);
36-
Log.LogDebugTaskItems (" ResourceDirectories: ", ResourceDirectories);
37-
3833
Yield ();
3934
try {
4035
var task = this.RunTask (DoExecute);

‎src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Link.cs

-3
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ public class Aapt2Link : Aapt2 {
7777

7878
public override bool Execute ()
7979
{
80-
if (CreatePackagePerAbi)
81-
Log.LogDebugMessage (" SupportedAbis: {0}", SupportedAbis);
82-
8380
Yield ();
8481
try {
8582
var task = this.RunTask (DoExecute);

‎src/Xamarin.Android.Build.Tasks/Tasks/AdjustJavacVersionArguments.cs

-6
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ public class AdjustJavacVersionArguments : Task
2929

3030
public override bool Execute ()
3131
{
32-
Log.LogDebugMessage ($"{nameof (DefaultJdkVersion)}: {DefaultJdkVersion}");
33-
Log.LogDebugMessage ("EnableProguard: {0}", EnableProguard);
34-
Log.LogDebugMessage ("EnableMultiDex: {0}", EnableMultiDex);
35-
Log.LogDebugMessage ($"{nameof (JdkVersion)}: {JdkVersion}");
36-
Log.LogDebugMessage ("SkipJavacVersionCheck: {0}", SkipJavacVersionCheck);
37-
3832
if (JdkVersion.StartsWith ("9", StringComparison.OrdinalIgnoreCase)) {
3933
TargetVersion = SourceVersion = DefaultJdkVersion;
4034
}

‎src/Xamarin.Android.Build.Tasks/Tasks/AndroidApkSigner.cs

-6
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ public class AndroidApkSigner : JavaToolTask
3333

3434
public override bool Execute ()
3535
{
36-
Log.LogDebugMessage ("AndroidApkSigner:");
37-
Log.LogDebugMessage (" ApkSignerJar: {0}", ApkSignerJar);
38-
Log.LogDebugMessage (" ApkToSign: {0}", ApkToSign);
39-
Log.LogDebugMessage (" ManifestFile: {0}", ManifestFile);
40-
Log.LogDebugMessage (" AdditionalArguments: {0}", AdditionalArguments);
41-
4236
if (!File.Exists (GenerateFullPathToTool ())) {
4337
Log.LogError ($"'{GenerateFullPathToTool ()}' does not exist. You need to install android-sdk build-tools 26.0.1 or above.");
4438
return false;

‎src/Xamarin.Android.Build.Tasks/Tasks/AndroidCreateDebugKey.cs

-8
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@ public AndroidCreateDebugKey ()
1919
Validity = 30 * 365; // 30 years
2020
}
2121

22-
public override bool Execute ()
23-
{
24-
Log.LogDebugMessage ("AndroidCreateDebugKey : {0}", Command);
25-
Log.LogDebugMessage (" {0}",Validity);
26-
Log.LogDebugMessage (" {0}",KeyAlgorithm);
27-
return base.Execute ();
28-
}
29-
3022
protected override CommandLineBuilder CreateCommandLine ()
3123
{
3224
var cmd = base.CreateCommandLine ();

‎src/Xamarin.Android.Build.Tasks/Tasks/AndroidUpdateResDir.cs

-11
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,6 @@ public class AndroidComputeResPaths : Task
5959

6060
public override bool Execute ()
6161
{
62-
Log.LogDebugMessage (" IntermediateDir: {0}", IntermediateDir);
63-
Log.LogDebugMessage (" Prefixes: {0}", Prefixes);
64-
Log.LogDebugMessage (" ProjectDir: {0}", ProjectDir);
65-
Log.LogDebugMessage (" LowercaseFilenames: {0}", LowercaseFilenames);
66-
Log.LogDebugTaskItems (" ResourceFiles:", ResourceFiles);
67-
6862
var intermediateFiles = new List<ITaskItem> ();
6963
var resolvedFiles = new List<ITaskItem> ();
7064

@@ -155,11 +149,6 @@ public class RemoveUnknownFiles : Task
155149

156150
public override bool Execute ()
157151
{
158-
Log.LogDebugMessage ("RemoveUnknownFiles Task");
159-
Log.LogDebugTaskItems ("Files", Files);
160-
Log.LogDebugMessage ($"Directory {Directory}");
161-
Log.LogDebugMessage ($"RemoveDirectories {RemoveDirectories}");
162-
163152
var absDir = Path.GetFullPath (Directory);
164153

165154
HashSet<string> knownFiles;

‎src/Xamarin.Android.Build.Tasks/Tasks/AndroidZipAlign.cs

-10
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,6 @@ protected override string GenerateCommandLineCommands ()
4040
Alignment, Source.ItemSpec, DestinationDirectory.ItemSpec, Path.DirectorySeparatorChar, sourceFilename);
4141
}
4242

43-
public override bool Execute ()
44-
{
45-
Log.LogDebugMessage ("AndroidZipAlign Task");
46-
Log.LogDebugMessage (" Alignment: {0}", Alignment);
47-
Log.LogDebugMessage (" Source: {0}", Source.ItemSpec);
48-
Log.LogDebugMessage (" DestinationDirectory: {0}", DestinationDirectory.ItemSpec);
49-
50-
return base.Execute ();
51-
}
52-
5343
protected override string GenerateFullPathToTool ()
5444
{
5545
return Path.Combine (ToolPath, ToolExe);

‎src/Xamarin.Android.Build.Tasks/Tasks/CalculateAdditionalResourceCacheDirectories.cs

-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ public class CalculateAdditionalResourceCacheDirectories : Task
2323

2424
public override bool Execute ()
2525
{
26-
Log.LogDebugMessage ("CalculateAdditionalResourceCacheDirectories Task");
27-
Log.LogDebugTaskItems (" AdditionalAndroidResourcePaths:", AdditionalAndroidResourcePaths);
28-
Log.LogDebugMessage (" CacheDirectory: {0}", CacheDirectory);
29-
3026
if (!AdditionalAndroidResourcePaths.Any ())
3127
return true;
3228

‎src/Xamarin.Android.Build.Tasks/Tasks/CalculateLayoutCodeBehind.cs

-7
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@ sealed class LayoutGroup
113113

114114
public override bool Execute ()
115115
{
116-
Log.LogDebugMessage ("CalculateLayoutCodeBehind Task");
117-
Log.LogDebugMessage ($" OutputLanguage: {OutputLanguage}");
118-
Log.LogDebugMessage ($" OutputFileExtension: {OutputFileExtension}");
119-
Log.LogDebugMessage ($" BaseNamespace: {BaseNamespace}");
120-
Log.LogDebugMessage ($" BindingDependenciesCacheFile: {BindingDependenciesCacheFile}");
121-
Log.LogDebugTaskItems (" BoundLayouts:", BoundLayouts);
122-
123116
widgetWithId = XPathExpression.Compile ("//*[@android:id and string-length(@android:id) != 0] | //include[not(@android:id)]");
124117

125118
GenerateLayoutBindings.BindingGeneratorLanguage gen;

‎src/Xamarin.Android.Build.Tasks/Tasks/CheckDuplicateJavaLibraries.cs

-4
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ public class CheckDuplicateJavaLibraries : Task
1414

1515
public override bool Execute ()
1616
{
17-
Log.LogDebugTaskItems (" JavaSourceFiles:", JavaSourceFiles);
18-
Log.LogDebugTaskItems (" JavaLibraries:", JavaLibraries);
19-
Log.LogDebugTaskItems (" LibraryProjectJars:", LibraryProjectJars);
20-
2117
var jarFiles = (JavaSourceFiles != null) ? JavaSourceFiles.Where (f => f.ItemSpec.EndsWith (".jar")) : null;
2218
if (jarFiles != null && JavaLibraries != null)
2319
jarFiles = jarFiles.Concat (JavaLibraries);

‎src/Xamarin.Android.Build.Tasks/Tasks/CheckForRemovedItems.cs

-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ public class CheckForRemovedItems : Task
2020

2121
public override bool Execute ()
2222
{
23-
Log.LogDebugMessage ("RemoveUnknownFiles Task");
24-
Log.LogDebugTaskItems ("Files", Files);
25-
Log.LogDebugMessage (" Directory:", Directory);
26-
2723
var absDir = Path.GetFullPath (Directory);
2824

2925
HashSet<string> knownFiles;

‎src/Xamarin.Android.Build.Tasks/Tasks/CheckProjectItems.cs

-4
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ public class CheckProjectItems : Task
1717

1818
public override bool Execute ()
1919
{
20-
Log.LogDebugMessage ("CheckProjectItems Task");
21-
Log.LogDebugTaskItems (" NativeLibraries:", NativeLibraries);
22-
Log.LogDebugTaskItems (" JavaLibraries:", JavaLibraries);
23-
Log.LogDebugTaskItems (" JavaSourceFiles:", JavaSourceFiles);
2420
if (IsApplication && EmbeddedNativeLibraries != null && EmbeddedNativeLibraries.Length > 0) {
2521
foreach (ITaskItem lib in EmbeddedNativeLibraries) {
2622
Log.LogError (

‎src/Xamarin.Android.Build.Tasks/Tasks/ClassParse.cs

-5
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ public class ClassParse : Task
2525

2626
public override bool Execute ()
2727
{
28-
Log.LogDebugMessage ("ClassParse Task");
29-
Log.LogDebugMessage (" OutputFile: {0}", OutputFile);
30-
Log.LogTaskItems (" SourceJars: ", SourceJars);
31-
Log.LogTaskItems (" DocumentationPaths: ", DocumentationPaths);
32-
3328
using (var output = new StreamWriter (OutputFile, append: false,
3429
encoding: new UTF8Encoding (encoderShouldEmitUTF8Identifier: false))) {
3530
Bytecode.Log.OnLog = LogEventHandler;

‎src/Xamarin.Android.Build.Tasks/Tasks/ComputeHash.cs

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public class ComputeHash : Task {
2121

2222
public override bool Execute ()
2323
{
24-
Log.LogDebugTaskItems ("Source : ", Source);
2524
using (var sha1 = SHA1.Create ()) {
2625

2726
foreach (var item in Source) {

‎src/Xamarin.Android.Build.Tasks/Tasks/ConvertDebuggingFiles.cs

-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ public class ConvertDebuggingFiles : Task
1818

1919
public override bool Execute ()
2020
{
21-
Log.LogDebugMessage ("ConvertDebuggingFiles Task");
22-
Log.LogDebugMessage (" InputFiles: {0}", Files);
23-
2421
var convertedFiles = new List<ITaskItem> ();
2522
foreach (var file in Files) {
2623
var pdb = file.ItemSpec;

‎src/Xamarin.Android.Build.Tasks/Tasks/CopyAndConvertResources.cs

-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ public class CopyAndConvertResources : Task
3939

4040
public override bool Execute ()
4141
{
42-
Log.LogDebugMessage ("CopyAndConvertResources Task");
43-
Log.LogDebugTaskItems (" SourceFiles:", SourceFiles);
44-
Log.LogDebugTaskItems (" DestinationFiles:", DestinationFiles);
45-
Log.LogDebugMessage (" AcwMapFile: {0}", AcwMapFile);
46-
4742
if (SourceFiles.Length != DestinationFiles.Length)
4843
throw new ArgumentException ("source and destination count mismatch");
4944

‎src/Xamarin.Android.Build.Tasks/Tasks/CopyIfChanged.cs

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ public class CopyIfChanged : Task
2929

3030
public override bool Execute ()
3131
{
32-
Log.LogDebugMessage ("CopyIfChanged Task");
33-
Log.LogDebugTaskItems (" SourceFiles: {0}", SourceFiles);
34-
Log.LogDebugTaskItems (" DestinationFiles: {0}", DestinationFiles);
35-
3632
if (SourceFiles.Length != DestinationFiles.Length)
3733
throw new ArgumentException ("source and destination count mismatch");
3834

‎src/Xamarin.Android.Build.Tasks/Tasks/CreateAdditionalLibraryResourceCache.cs

-3
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ public class CreateAdditionalLibraryResourceCache : Task
2525

2626
public override bool Execute ()
2727
{
28-
Log.LogDebugMessage ("CreateAdditionalLibraryResourceCache Task");
29-
Log.LogDebugTaskItems (" AdditionalAndroidResourcePaths:", AdditionalAndroidResourcePaths);
30-
Log.LogDebugTaskItems (" AdditionalAndroidResourceCachePaths: ", AdditionalAndroidResourceCachePaths);
3128
var copiedResources = new List<ITaskItem> ();
3229

3330
for (int i = 0; i < AdditionalAndroidResourcePaths.Length; i++) {

‎src/Xamarin.Android.Build.Tasks/Tasks/CreateLibraryResourceArchive.cs

-12
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@ public override bool Execute ()
4040
if (LibraryProjectPropertiesFiles.Length == 0 && LibraryProjectZipFiles.Length == 0)
4141
return true;
4242

43-
Log.LogDebugMessage ("CreateLibraryResourceArchive Task");
44-
Log.LogDebugMessage (" OutputDirectory: {0}", OutputDirectory);
45-
Log.LogDebugMessage (" OutputJarsDirectory: {0}", OutputJarsDirectory);
46-
Log.LogDebugMessage (" OutputAnnotationsDirectory: {0}", OutputAnnotationsDirectory);
47-
Log.LogDebugMessage (" LibraryProjectProperties:");
48-
49-
foreach (var p in LibraryProjectPropertiesFiles)
50-
Log.LogDebugMessage (" " + p.ItemSpec);
51-
Log.LogDebugMessage (" LibraryProjectZip:");
52-
foreach (var z in LibraryProjectZipFiles)
53-
Log.LogDebugMessage (" " + z.ItemSpec);
54-
5543
var outDirInfo = new DirectoryInfo (OutputDirectory);
5644

5745
// Copy files into _LibraryProjectImportsDirectoryName (library_project_imports) dir.

‎src/Xamarin.Android.Build.Tasks/Tasks/CreateResgenManifest.cs

-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ public class CreateResgenManifest : Task
2121

2222
public override bool Execute ()
2323
{
24-
Log.LogDebugMessage ("CreateResgenManifest Task");
25-
Log.LogDebugMessage (" ManifestOutputFile: {0}", ManifestOutputFile);
26-
Log.LogDebugMessage (" PackageName: {0}", PackageName);
27-
2824
// <manifest xmlns:android="http://schemas.android.com/apk/res/android"
2925
// package="MonoAndroidApplication4.MonoAndroidApplication4" />
3026

‎src/Xamarin.Android.Build.Tasks/Tasks/CreateTemporaryDirectory.cs

-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ public override bool Execute ()
1616
{
1717
TemporaryDirectory = Path.Combine (Path.GetTempPath (), Path.GetRandomFileName ());
1818
Directory.CreateDirectory (TemporaryDirectory);
19-
20-
Log.LogDebugMessage ("CreateTemporaryDirectory Task");
2119
Log.LogDebugMessage (" OUTPUT: TemporaryDirectory: {0}", TemporaryDirectory);
2220

2321
return true;

‎src/Xamarin.Android.Build.Tasks/Tasks/Crunch.cs

-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ public override bool Execute ()
8686

8787
void DoExecute ()
8888
{
89-
LogDebugMessage ("Crunch Task");
90-
LogDebugTaskItems (" SourceFiles:", SourceFiles);
9189
// copy the changed files over to a temp location for processing
9290
var imageFiles = SourceFiles.Where (x => string.Equals (Path.GetExtension (x.ItemSpec),".png", StringComparison.OrdinalIgnoreCase));
9391

‎src/Xamarin.Android.Build.Tasks/Tasks/DetermineJavaLibrariesToCompile.cs

-10
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,6 @@ public class DetermineJavaLibrariesToCompile : Task
3535

3636
public override bool Execute ()
3737
{
38-
Log.LogDebugMessage ("DetermineJavaLibrariesToCompile");
39-
Log.LogDebugMessage (" EnableInstantRun: {0}", EnableInstantRun);
40-
Log.LogDebugMessage (" MonoPlatformJarPaths: {0}", MonoPlatformJarPaths);
41-
Log.LogDebugTaskItems (" JavaSourceFiles:", JavaSourceFiles);
42-
Log.LogDebugTaskItems (" JavaLibraries:", JavaLibraries);
43-
Log.LogDebugTaskItems (" ExternalJavaLibraries:", ExternalJavaLibraries);
44-
Log.LogDebugTaskItems (" LibraryProjectJars:", LibraryProjectJars);
45-
Log.LogDebugTaskItems (" AdditionalJavaLibraryReferences:", AdditionalJavaLibraryReferences);
46-
Log.LogDebugTaskItems (" DoNotPackageJavaLibraries:", DoNotPackageJavaLibraries);
47-
4838
var jars = new List<ITaskItem> ();
4939
if (!EnableInstantRun)
5040
jars.AddRange (MonoPlatformJarPaths);

‎src/Xamarin.Android.Build.Tasks/Tasks/FindLayoutsToBind.cs

-6
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ public class FindLayoutsToBind : Task
2828

2929
public override bool Execute ()
3030
{
31-
Log.LogDebugMessage ("FindLayoutsToBind Task");
32-
Log.LogDebugMessage ($" GenerateLayoutBindings: {GenerateLayoutBindings}");
33-
Log.LogDebugMessage ($" BindingDependenciesCacheFile: {BindingDependenciesCacheFile}");
34-
Log.LogDebugTaskItems (" BoundLayouts:", BoundLayouts);
35-
Log.LogDebugTaskItems (" ResourceFiles:", ResourceFiles);
36-
3731
var layouts = new Dictionary <string, ITaskItem> (StringComparer.OrdinalIgnoreCase);
3832
if (GenerateLayoutBindings) {
3933
Log.LogDebugMessage ("Collecting all layouts");

‎src/Xamarin.Android.Build.Tasks/Tasks/GenerateLayoutBindings.cs

-7
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,6 @@ public BindingGeneratorLanguage (string name, string extension, Func<BindingGene
7979

8080
public override bool Execute ()
8181
{
82-
Log.LogDebugMessage ("GenerateLayoutBindings Task");
83-
Log.LogDebugMessage ($" OutputLanguage: {OutputLanguage}");
84-
Log.LogDebugMessage ($" MonoAndroidCodeBehindDir: {MonoAndroidCodeBehindDir}");
85-
Log.LogDebugMessage ($" AppNamespace: {AppNamespace}");
86-
Log.LogDebugTaskItems (" ResourceFiles:", ResourceFiles, true);
87-
Log.LogDebugTaskItems (" PartialClassFiles:", PartialClassFiles, true);
88-
8982
if (String.IsNullOrWhiteSpace (OutputLanguage))
9083
OutputLanguage = DefaultOutputGenerator.Name;
9184

‎src/Xamarin.Android.Build.Tasks/Tasks/GenerateLayoutCodeBehind.cs

-4
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,6 @@ enum MethodScope {
100100

101101
public override bool Execute ()
102102
{
103-
Log.LogDebugMessage ("GenerateCodeBehindForLayout Task");
104-
Log.LogDebugMessage (" MonoAndroidCodeBehindDir: {0}", MonoAndroidCodeBehindDir);
105-
Log.LogDebugTaskItems (" ResourceFiles:", ResourceFiles);
106-
107103
var generatedFiles = new List<ITaskItem> ();
108104

109105
var generatorOptions = new CodeGeneratorOptions {

‎src/Xamarin.Android.Build.Tasks/Tasks/GenerateManagedAidlProxies.cs

-7
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ public GenerateManagedAidlProxies ()
3434

3535
public override bool Execute ()
3636
{
37-
Log.LogDebugMessage ("Task GenerateManagedAidlProxies");
38-
Log.LogDebugTaskItems (" References:", References);
39-
Log.LogDebugTaskItems (" SourceAidlFiles:", SourceAidlFiles);
40-
Log.LogDebugMessage (" IntermediateOutputDirectory: {0}", IntermediateOutputDirectory);
41-
Log.LogDebugMessage (" OutputNamespace: {0}", OutputNamespace);
42-
Log.LogDebugMessage (" ParcelableHandlingOption: {0}", ParcelableHandlingOption);
43-
4437
if (SourceAidlFiles.Length == 0) // nothing to do
4538
return true;
4639

‎src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs

-11
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,6 @@ public override bool Execute ()
5555
// Use "Application" as the default namespace name to work with XS.
5656
Namespace = Namespace ?? "Application";
5757

58-
Log.LogDebugMessage ("GenerateResourceDesigner Task");
59-
Log.LogDebugMessage (" NetResgenOutputFile: {0}", NetResgenOutputFile);
60-
Log.LogDebugMessage (" JavaResgenInputFile: {0}", JavaResgenInputFile);
61-
Log.LogDebugMessage (" Namespace: {0}", Namespace);
62-
Log.LogDebugMessage (" ResourceDirectory: {0}", ResourceDirectory);
63-
Log.LogDebugTaskItemsAndLogical (" AdditionalResourceDirectories:", AdditionalResourceDirectories);
64-
Log.LogDebugMessage (" IsApplication: {0}", IsApplication);
65-
Log.LogDebugMessage (" UseManagedResourceGenerator: {0}", UseManagedResourceGenerator);
66-
Log.LogDebugTaskItemsAndLogical (" Resources:", Resources);
67-
Log.LogDebugTaskItemsAndLogical (" References:", References);
68-
6958
if (!File.Exists (JavaResgenInputFile) && !UseManagedResourceGenerator)
7059
return true;
7160

0 commit comments

Comments
 (0)