Custom dialect resource files not loaded and shown as expected

[Ronzan]

Not sure if this is a bug or by design.
My issue is that we have custom dialects in our project.
That is, we have .resx files with custom language codes like: en-GB-dev or en-GB-x-abc.
These custom dialect files are seen as separate resources and not as different languages.

ResXResourceManager:

This is apparently also an issue for VS, this is the folder in the project:

To Reproduce
Add two resource files with standard dialects, en-GB and en-US
Add a resource file with a custom dialects, en-GB-dev
Open ResXResourceManager and observe.

Expected behavior
I expected ResXResourceManager to show custom dialects the same way it shows standard dialects.

Is this an issue with ResXResourceManager, .NET, VS or what? :-)

[tom-englert]

Currently RXRM considers only languages known by Windows (anything returned by CultureInfo.GetCultures(CultureTypes.AllCultures)):

ResXResourceManager/src/ResXManager.Model/ResourceManager.cs

Lines 269 to 292 in 96ec5cc

	public static bool IsValidLanguageName(string? languageName)
	{
	if (languageName.IsNullOrEmpty())
	return false;
	return Array.BinarySearch(_sortedCultureNames, languageName, StringComparer.OrdinalIgnoreCase) >= 0;
	}
	private static string[] GetSortedCultureNames()
	{
	var allCultures = CultureInfo.GetCultures(CultureTypes.AllCultures);
	var pseudoLocales = new[] { "qps-ploc", "qps-ploca", "qps-plocm", "qps-Latn-x-sh" };
	var cultureNames = allCultures
	.SelectMany(culture => new[] { culture.IetfLanguageTag, culture.Name })
	.Concat(pseudoLocales)
	.Distinct()
	.ToArray();
	Array.Sort(cultureNames, StringComparer.OrdinalIgnoreCase);
	return cultureNames;
	}

Maybe you have a better approach?

[Ronzan]

I haven't looked over the source much yet, and I haven't found where the resx files are actually loaded.
I think the .GetCultures() makes good sense for the list of languages, I don't see a better option for that.
I'll see if I can find where RXRM is deciding what files to load :)

[tom-englert]

Actually the files will be loaded. However since en-GB-dev is not detected as a valid language name, it is treated as the neutral culture of the SharedResource.en-GB-dev, not as a specific culture of SharedResource

[Ronzan]

Thank you very much @tom-englert, it works perfectly :)
Much appreciated.