Updating the tests coverage (#211)

* Ensure tests run for Latest vs Compat and Unix vs Window modes

* Ensure \n is used in the xml generator

* Fixing up some running on unix vs windows test differences

Author: tannergooding

sources/ClangSharp.PInvokeGenerator/Abstractions/IOutputBuilder.VisitDecl.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using ClangSharp.CSharp;
 
 namespace ClangSharp.Abstractions

sources/ClangSharp.PInvokeGenerator/Abstractions/IOutputBuilder.cs

@@ -1,5 +1,3 @@
-using System.Collections.Generic;
-
 namespace ClangSharp.Abstractions
 {
     internal partial interface IOutputBuilder

sources/ClangSharp.PInvokeGenerator/CSharp/CSharpOutputBuilder.VisitDecl.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 using System.Runtime.InteropServices;

sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitDecl.cs

@@ -3,7 +3,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Globalization;
 using System.Linq;
 using System.Runtime.InteropServices;
 using System.Text;

sources/ClangSharp.PInvokeGenerator/XML/XmlOutputBuilder.Visit.cs

@@ -3,7 +3,7 @@ namespace ClangSharp.XML
     internal partial class XmlOutputBuilder
     {
         public void WriteCustomAttribute(string attribute)
-            => _sb.AppendLine($"<attribute>{attribute}</attribute>");
+            => _sb.Append($"<attribute>{attribute}</attribute>\n");
         public void WriteIid(string iidName, string iidValue)
         {
             _sb.Append("<iid name=\"");

sources/ClangSharp.PInvokeGenerator/XML/XmlOutputBuilder.VisitDecl.cs

@@ -297,11 +297,12 @@ public void EndCSharpCode(CSharpOutputBuilder output)
             output.WritePendingLine();
             foreach (var s in output.Contents)
             {
-                _sb.AppendLine(s.Replace("&", "&")
+                _sb.Append(s.Replace("&", "&")
                     .Replace("<", "&lt;")
                     .Replace(">", "&gt;")
                     .Replace("/*M*/&lt;", "<")
                     .Replace("/*M*/&gt;", ">"));
+                _sb.Append('\n');
             }
 
             _sb.Append("</code>");

sources/ClangSharp.PInvokeGenerator/XML/XmlOutputBuilder.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Xml;
 using System.Xml.Linq;
 using ClangSharp.Abstractions;
@@ -27,7 +26,8 @@ public IEnumerable<string> Contents
                 {
                     Indent = true,
                     IndentChars = "    ",
-                    ConformanceLevel = ConformanceLevel.Fragment
+                    ConformanceLevel = ConformanceLevel.Fragment,
+                    NewLineChars = "\n",
                 });
 
                 foreach (var node in XElement.Parse("<tmp>" + _sb + "</tmp>").Nodes())

sources/ClangSharp/TranslationUnit.cs

@@ -144,7 +144,11 @@ private void Dispose(bool isDisposing)
             {
                 Handle.Dispose();
             }
-            _createdTranslationUnits.Remove(Handle);
+
+            lock (_createTranslationUnitLock)
+            {
+                _createdTranslationUnits.Remove(Handle);
+            }
         }
     }
 }

tests/ClangSharp.PInvokeGenerator.UnitTests/Base/CXXMethodDeclarationTest.cs

@@ -0,0 +1,55 @@
+// Copyright (c) Microsoft and Contributors. All rights reserved. Licensed under the University of Illinois/NCSA Open Source License. See LICENSE.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ClangSharp.UnitTests
+{
+    public abstract class CXXMethodDeclarationTest : PInvokeGeneratorTest
+    {
+        [Fact]
+        public abstract Task ConstructorTest();
+
+        [Fact]
+        public abstract Task ConstructorWithInitializeTest();
+
+        [Fact]
+        public abstract Task ConversionTest();
+
+        [Fact]
+        public abstract Task DestructorTest();
+
+        [Fact]
+        public abstract Task InstanceTest();
+
+        [Fact]
+        public abstract Task MemberCallTest();
+
+        [Fact]
+        public abstract Task MemberTest();
+
+        [Fact]
+        public abstract Task NewKeywordTest();
+
+        [Fact]
+        public abstract Task NewKeywordVirtualTest();
+
+        [Fact]
+        public abstract Task OperatorTest();
+
+        [Fact]
+        public abstract Task OperatorCallTest();
+
+        [Fact]
+        public abstract Task StaticTest();
+
+        [Fact]
+        public abstract Task ThisTest();
+
+        [Fact]
+        public abstract Task UnsafeDoesNotImpactDllImportTest();
+
+        [Fact]
+        public abstract Task VirtualTest();
+    }
+}

tests/ClangSharp.PInvokeGenerator.UnitTests/Base/EnumDeclarationTest.cs

@@ -0,0 +1,74 @@
+// Copyright (c) Microsoft and Contributors. All rights reserved. Licensed under the University of Illinois/NCSA Open Source License. See LICENSE.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ClangSharp.UnitTests
+{
+    public abstract class EnumDeclarationTest : PInvokeGeneratorTest
+    {
+        [Fact]
+        public abstract Task BasicTest();
+
+        [Fact]
+        public abstract Task BasicValueTest();
+
+        [Fact]
+        public abstract Task ExcludeTest();
+
+        [Theory]
+        [InlineData("short", "short")]
+        public abstract Task ExplicitTypedTest(string nativeType, string expectedManagedType);
+
+        [Theory]
+        [InlineData("unsigned char", "byte")]
+        [InlineData("long long", "long")]
+        [InlineData("signed char", "sbyte")]
+        [InlineData("unsigned short", "ushort")]
+        [InlineData("unsigned int", "uint")]
+        [InlineData("unsigned long long", "ulong")]
+        public abstract Task ExplicitTypedWithNativeTypeNameTest(string nativeType, string expectedManagedType);
+
+        [Fact]
+        public abstract Task RemapTest();
+
+        [Fact]
+        public abstract Task WithAttributeTest();
+
+        [Fact]
+        public abstract Task WithAttributeStarTest();
+
+        [Fact]
+        public abstract Task WithAttributeStarPlusTest();
+
+        [Fact]
+        public abstract Task WithNamespaceTest();
+
+        [Fact]
+        public abstract Task WithNamespaceStarTest();
+
+        [Fact]
+        public abstract Task WithNamespaceStarPlusTest();
+
+        [Fact]
+        public abstract Task WithCastToEnumType();
+
+        [Fact]
+        public abstract Task WithMultipleEnumsTest();
+
+        [Fact]
+        public abstract Task WithImplicitConversionTest();
+
+        [Fact]
+        public abstract Task WithTypeTest();
+
+        [Fact]
+        public abstract Task WithTypeAndImplicitConversionTest();
+
+        [Fact]
+        public abstract Task WithTypeStarTest();
+
+        [Fact]
+        public abstract Task WithTypeStarOverrideTest();
+    }
+}