From d07153105be602b927f53f9db2a09c2f3c1f269b Mon Sep 17 00:00:00 2001 From: ntr Date: Thu, 17 Aug 2023 13:51:26 +0200 Subject: [PATCH 1/3] Make MarkdownExporter ctor and Dialect protected --- src/BenchmarkDotNet/Exporters/MarkdownExporter.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs index 1d3bc5171b..068ea8b247 100644 --- a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs +++ b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs @@ -22,8 +22,6 @@ public enum MarkdownHighlightStrategy protected override string FileExtension => "md"; protected override string FileNameSuffix => $"-{Dialect.ToLower()}"; - private string Dialect { get; set; } - public static readonly IExporter Default = new MarkdownExporter { Dialect = nameof(Default), @@ -74,6 +72,7 @@ public enum MarkdownHighlightStrategy StartOfGroupHighlightStrategy = MarkdownHighlightStrategy.Marker }; + [PublicAPI] protected string Dialect { get; set; } [PublicAPI] protected string Prefix = string.Empty; [PublicAPI] protected bool UseCodeBlocks; [PublicAPI] protected string CodeBlockStart = "```"; @@ -86,7 +85,7 @@ public enum MarkdownHighlightStrategy [PublicAPI] protected string BoldMarkupFormat = "**{0}**"; [PublicAPI] protected bool EscapeHtml; - private MarkdownExporter() { } + protected MarkdownExporter() { } public override void ExportToLog(Summary summary, ILogger logger) { From 229304fabd3d98831edc8ee0c99bba1954231f9b Mon Sep 17 00:00:00 2001 From: ntr Date: Thu, 17 Aug 2023 13:52:16 +0200 Subject: [PATCH 2/3] nit --- src/BenchmarkDotNet/Exporters/MarkdownExporter.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs index 068ea8b247..00e64d6d1b 100644 --- a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs +++ b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs @@ -22,6 +22,8 @@ public enum MarkdownHighlightStrategy protected override string FileExtension => "md"; protected override string FileNameSuffix => $"-{Dialect.ToLower()}"; + [PublicAPI] protected string Dialect { get; set; } + public static readonly IExporter Default = new MarkdownExporter { Dialect = nameof(Default), @@ -72,7 +74,6 @@ public enum MarkdownHighlightStrategy StartOfGroupHighlightStrategy = MarkdownHighlightStrategy.Marker }; - [PublicAPI] protected string Dialect { get; set; } [PublicAPI] protected string Prefix = string.Empty; [PublicAPI] protected bool UseCodeBlocks; [PublicAPI] protected string CodeBlockStart = "```"; From 5738c27a651467ede166b723967a663a17345434 Mon Sep 17 00:00:00 2001 From: ntr Date: Thu, 17 Aug 2023 13:52:26 +0200 Subject: [PATCH 3/3] nit --- src/BenchmarkDotNet/Exporters/MarkdownExporter.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs index 00e64d6d1b..096ae84b52 100644 --- a/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs +++ b/src/BenchmarkDotNet/Exporters/MarkdownExporter.cs @@ -22,7 +22,7 @@ public enum MarkdownHighlightStrategy protected override string FileExtension => "md"; protected override string FileNameSuffix => $"-{Dialect.ToLower()}"; - [PublicAPI] protected string Dialect { get; set; } + protected string Dialect { get; set; } public static readonly IExporter Default = new MarkdownExporter {