Order of State changes and OnTransitionCompleted execution.

[kagerouttepaso]

Hello.

I found that the order of the stateMutator call (updating the State) and the OnTransitionCompleted call is different in ReEntry and otherwise.

In the following source code, the order of the calls seems to be different.

stateless/src/Stateless/StateMachine.cs

Lines 428 to 452 in e25f4da

	private void HandleReentryTrigger(object[] args, StateRepresentation representativeState, Transition transition)
	{
	StateRepresentation representation;
	transition = representativeState.Exit(transition);
	var newRepresentation = GetRepresentation(transition.Destination);
	if (!transition.Source.Equals(transition.Destination))
	{
	// Then Exit the final superstate
	transition = new Transition(transition.Destination, transition.Destination, transition.Trigger, args);
	newRepresentation.Exit(transition);
	_onTransitionedEvent.Invoke(transition);
	representation = EnterState(newRepresentation, transition, args);
	_onTransitionCompletedEvent.Invoke(transition);
	}
	else
	{
	_onTransitionedEvent.Invoke(transition);
	representation = EnterState(newRepresentation, transition, args);
	_onTransitionCompletedEvent.Invoke(transition);
	}
	State = representation.UnderlyingState;
	}

stateless/src/Stateless/StateMachine.cs

Lines 454 to 473 in e25f4da

	private void HandleTransitioningTrigger( object[] args, StateRepresentation representativeState, Transition transition)
	{
	transition = representativeState.Exit(transition);
	State = transition.Destination;
	var newRepresentation = GetRepresentation(transition.Destination);
	//Alert all listeners of state transition
	_onTransitionedEvent.Invoke(transition);
	var representation = EnterState(newRepresentation, transition, args);
	// Check if state has changed by entering new state (by fireing triggers in OnEntry or such)
	if (!representation.UnderlyingState.Equals(State))
	{
	// The state has been changed after entering the state, must update current state to new one
	State = representation.UnderlyingState;
	}
	_onTransitionCompletedEvent.Invoke(new Transition(transition.Source, State, transition.Trigger, transition.Parameters));
	}

I think the order of the calls should be more consistent.

[HenningNT]

I think you are correct.