Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Bad practices in Bicep files #132

Open
Makciek opened this issue Feb 10, 2023 · 0 comments
Open

Bad practices in Bicep files #132

Makciek opened this issue Feb 10, 2023 · 0 comments

Comments

@Makciek
Copy link

Makciek commented Feb 10, 2023

Hello
I checked the bicep files in this project and found that secrets are passed by the outputs(especially the cosmos key) which according to docs should not be:
https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/scenarios-secrets#avoid-outputs-for-secrets

Issue example:
https://github.com/dotnet-architecture/eShopOnDapr/blob/main/deploy/containerapps/modules/infra/cosmos-db.bicep#L57

Should this be fixed or at least a disclaimer be added?

@Makciek Makciek changed the title Bad practices in Bicep files - should a disclaimer be added? Bad practices in Bicep files Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant