Swamy/01jan2021-small-refactoring (#1570)

* Update Startup.cs

* Removed commented code

* Update UrlsConfig.cs

* Small Refactoring

* Removed Commented Code

* Small Refactoring

Author: vishipayyallore

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Models/OrderData.cs

@@ -42,7 +42,7 @@ public class OrderData
 
         public string Buyer { get; set; }
 
-        public List<OrderItemData> OrderItems { get;  } = new List<OrderItemData>();
+        public List<OrderItemData> OrderItems { get; } = new List<OrderItemData>();
     }
 
 }

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Models/UpdateBasketItemsRequest.cs

@@ -5,7 +5,7 @@ namespace Microsoft.eShopOnContainers.Mobile.Shopping.HttpAggregator.Models
 
     public class UpdateBasketItemsRequest
     {
-        
+
         public string BasketId { get; set; }
 
         public ICollection<UpdateBasketItemData> Updates { get; set; }

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Models/UpdateBasketRequest.cs

@@ -2,7 +2,7 @@
 
 namespace Microsoft.eShopOnContainers.Mobile.Shopping.HttpAggregator.Models
 {
-    
+
     public class UpdateBasketRequest
     {
         public string BuyerId { get; set; }

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/BasketService.cs

@@ -27,7 +27,7 @@ public async Task<BasketData> GetById(string id)
         {
             return await GrpcCallerService.CallService(_urls.GrpcBasket, async channel =>
             {
-                
+
                 var client = new Basket.BasketClient(channel);
                 _logger.LogDebug("grpc client created, request = {@id}", id);
                 var response = await client.GetBasketByIdAsync(new BasketRequest { Id = id });

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/CatalogService.cs

@@ -36,7 +36,7 @@ public async Task<CatalogItem> GetCatalogItemAsync(int id)
         public async Task<IEnumerable<CatalogItem>> GetCatalogItemsAsync(IEnumerable<int> ids)
         {
 
-            return await GrpcCallerService.CallService(_urls.GrpcCatalog, async channel=>
+            return await GrpcCallerService.CallService(_urls.GrpcCatalog, async channel =>
             {
                 var client = new CatalogClient(channel);
                 var request = new CatalogItemsRequest { Ids = string.Join(",", ids), PageIndex = 1, PageSize = 10 };

src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/GrpcCallerService.cs

@@ -15,15 +15,6 @@ public static async Task<TResponse> CallService<TResponse>(string urlGrpc, Func<
 
             var channel = GrpcChannel.ForAddress(urlGrpc);
 
-            /*
-            using var httpClientHandler = new HttpClientHandler
-            {
-                ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; }
-            };
-
-            */
-
-
             Log.Information("Creating grpc client base address urlGrpc ={@urlGrpc}, BaseAddress={@BaseAddress} ", urlGrpc, channel.Target);
 
             try
@@ -47,13 +38,6 @@ public static async Task CallService(string urlGrpc, Func<GrpcChannel, Task> fun
             AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport", true);
             AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2Support", true);
 
-            /*
-            using var httpClientHandler = new HttpClientHandler
-            {
-                ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; }
-            };
-            */
-
             var channel = GrpcChannel.ForAddress(urlGrpc);
 
             Log.Debug("Creating grpc client base address {@httpClient.BaseAddress} ", channel.Target);

src/ApiGateways/Web.Bff.Shopping/aggregator/Config/UrlsConfig.cs

@@ -20,7 +20,7 @@ public class CatalogOperations
         public class BasketOperations
         {
             public static string GetItemById(string id) => $"/api/v1/basket/{id}";
-            
+
             public static string UpdateBasket() => "/api/v1/basket";
         }
 

src/ApiGateways/Web.Bff.Shopping/aggregator/Services/GrpcCallerService.cs

@@ -15,15 +15,6 @@ public static async Task<TResponse> CallService<TResponse>(string urlGrpc, Func<
 
             var channel = GrpcChannel.ForAddress(urlGrpc);
 
-            /*
-            using var httpClientHandler = new HttpClientHandler
-            {
-                ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; }
-            };
-
-            */
-
-
             Log.Information("Creating grpc client base address urlGrpc ={@urlGrpc}, BaseAddress={@BaseAddress} ", urlGrpc, channel.Target);
 
             try
@@ -49,13 +40,6 @@ public static async Task CallService(string urlGrpc, Func<GrpcChannel, Task> fun
             AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport", true);
             AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2Support", true);
 
-            /*
-            using var httpClientHandler = new HttpClientHandler
-            {
-                ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => { return true; }
-            };
-            */
-
             var channel = GrpcChannel.ForAddress(urlGrpc);
 
             Log.Debug("Creating grpc client base address {@httpClient.BaseAddress} ", channel.Target);

src/ApiGateways/Web.Bff.Shopping/aggregator/Startup.cs

@@ -63,7 +63,7 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ILoggerF
             {
                 app.UseDeveloperExceptionPage();
             }
-            
+
             app.UseHttpsRedirection();
 
             app.UseSwagger().UseSwaggerUI(c =>