Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer patch-package approach instead of module augmentation? #23

Closed
dotansimha opened this issue Jul 29, 2020 · 1 comment
Closed

Prefer patch-package approach instead of module augmentation? #23

dotansimha opened this issue Jul 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dotansimha
Copy link
Owner

dotansimha commented Jul 29, 2020

We can PR libraries to add support, and create a patch file from the dist output of those libraries. This way it can be used without module augmentation, and solve issues like #15

I started to create PRs for libraries to support this built-in:

Thoughts:

  • patch-package needs to support patches from npm module (should be able to do that with --patch-dir flag), or from a url (which isn't supported at the moment, according to the issues)
  • Simplify the setup of this package, get rid of support packages, and ship patches as part of the core library? 🤔
@dotansimha dotansimha changed the title Prefer patch-patch approach instead of module augmentation? Prefer patch-package approach instead of module augmentation? Jul 29, 2020
@dotansimha dotansimha added the enhancement New feature or request label Jul 30, 2020
@dotansimha
Copy link
Owner Author

dotansimha commented Aug 2, 2020

Done in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant