Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pistol.conf could be better #31

Closed
lucas-mior opened this issue Jul 10, 2020 · 6 comments
Closed

pistol.conf could be better #31

lucas-mior opened this issue Jul 10, 2020 · 6 comments

Comments

@lucas-mior
Copy link
Contributor

lucas-mior commented Jul 10, 2020

I noticed that parsing of pistol.conf fails when there is more than one space between the mime type and preview program.
Which makes the config file really messy.

@doronbehar
Copy link
Owner

Could you give please a concrete example?

@lucas-mior
Copy link
Contributor Author

lucas-mior commented Jul 11, 2020

GitHub won't let me put two spaces in a row, I'll try to explain the best I can.
inode/directory ls -1A --color %pistol-filename% <-- works, but won't if there is one more space character between directory and ls. It makes easy for errors to occur just because of one extra space character.
Also I can't align the mime types / programs properly, making the config file confusing to read and mantain.

@doronbehar
Copy link
Owner

Thanks for catching that, I improved the config file's parsing, and I hope that works for you. A new release is available.

@lucas-mior
Copy link
Contributor Author

Indeed, it works now, but I also noticed that empty lines (previously ignored) now break the config parsing.
Not a problem for me, but might break someone else's config.

@doronbehar doronbehar reopened this Jul 13, 2020
@doronbehar
Copy link
Owner

It should work now.

https://www.reddit.com/r/ProgrammerHumor/comments/hp9wwp/biggest_lie/

@lucas-mior
Copy link
Contributor Author

It does, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants