Skip to content

fix(IBL): glowing metals in shadow #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davo0411 wants to merge 1 commit into from
Closed

fix(IBL): glowing metals in shadow #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions features/Dynamic Cubemaps/Shaders/DynamicCubemaps/DynamicCubemaps.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ namespace DynamicCubemaps
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# endif
} else {
// Mode 0/1: IBL ratio-based
Expand All @@ -81,6 +82,7 @@ namespace DynamicCubemaps
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# endif
}

Expand Down Expand Up @@ -179,6 +181,7 @@ namespace DynamicCubemaps
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# endif
} else {
// Mode 0/1: IBL ratio-based
Expand All @@ -187,6 +190,7 @@ namespace DynamicCubemaps
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# endif
}

Expand Down
2 changes: 2 additions & 0 deletions package/Shaders/DeferredCompositeCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ void SampleSSGISpecular(uint2 pixCoord, sh2 lobe, inout float ao, out float3 il,
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# elif defined(INTERIOR)
skySpecular = 0;
# endif
Expand All @@ -227,6 +228,7 @@ void SampleSSGISpecular(uint2 pixCoord, sh2 lobe, inout float ao, out float3 il,
skySpecular = Color::IrradianceToLinear(max(0, fullSample - envSample)) * SharedData::iblSettings.SkyIBLScale;
# if defined(SKYLIGHTING)
skySpecular *= skylightingSpecular;
envSpecular *= skylightingSpecular;
# elif defined(INTERIOR)
skySpecular = 0;
# endif
Expand Down
Loading