Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectedDayTextStyle is overridden by todayTextStyle #104

Closed
jkmathew opened this issue May 9, 2019 · 0 comments · Fixed by #144
Closed

selectedDayTextStyle is overridden by todayTextStyle #104

jkmathew opened this issue May 9, 2019 · 0 comments · Fixed by #144
Labels
bug Something isn't working

Comments

@jkmathew
Copy link

jkmathew commented May 9, 2019

Version of flutter_calendar_carousel

1.3.16

Expected behavior

If user select current day, it should render in selected days style.

Actual behavior

If user select current day, Renderingit in today text style itself.
Happens only when weekFormat: true,.
When weekFormat: false,, working fine.

flutter doctor result (run flutter doctor in terminal)

$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.4.19-pre.3, on Mac OS X 10.14.4 18E226, locale
    en-DE)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[!] iOS toolchain - develop for iOS devices (Xcode 10.2)
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
[✓] Android Studio (version 3.3)
[!] IntelliJ IDEA Ultimate Edition (version 2019.1.1)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
[✓] Connected device (1 available)

! Doctor found issues in 2 categories.

Steps to reproduce the behavior

    final themeColor = Color(0xFF449955);

    CalendarCarousel _calendarCarousel = CalendarCarousel<int>(
      thisMonthDayBorderColor: Colors.transparent,
      dayPadding: 6,
      todayButtonColor: Colors.transparent,
      todayBorderColor: themeColor,
      selectedDayBorderColor: themeColor,
      daysHaveCircularBorder: true,
      height: 165,
      selectedDateTime: _currentDate,
      customGridViewPhysics: NeverScrollableScrollPhysics(),
      weekFormat: true,
      selectedDayButtonColor: themeColor,
      todayTextStyle: TextStyle(fontSize: 16, fontWeight: FontWeight.normal, color: themeColor),
      selectedDayTextStyle: TextStyle(fontSize: 16, fontWeight: FontWeight.normal, color: Colors.white),
      onDayPressed: (DateTime date, List<int> events) {
        this.setState(() => _currentDate = date);
      },
    );

Select Today
TodaySelect

Select other days
OtherDaySlelect

Select Today on weekFormat: false,
Month format

Related to #63

@hyochan hyochan added the bug Something isn't working label May 20, 2019
@hyochan hyochan mentioned this issue Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants