Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS Tree once a version >3.0.1 is out #1378

Closed
tidoust opened this issue Nov 4, 2024 · 1 comment · Fixed by #1404 or doni108108doni/webref#10 · May be fixed by doni108108doni/webref#8
Closed

Update CSS Tree once a version >3.0.1 is out #1378

tidoust opened this issue Nov 4, 2024 · 1 comment · Fixed by #1404 or doni108108doni/webref#10 · May be fixed by doni108108doni/webref#8

Comments

@tidoust
Copy link
Member

tidoust commented Nov 4, 2024

Dependabot currently detects that v3.0.1 exists but says "No update possible for css-tree 2.3.1" in its logs. I don't understand why.
We're going to need to bump CSS Tree once a new version gets released (so that we may drop the patch on css-values-5). I'm creating this issue both to understand why dependabot refuses to create a PR by itself and to track switch to the new version.

@romainmenke
Copy link
Member

CSS Tree 3.1.0 was released: https://github.com/csstree/csstree/releases/tag/v3.1.0

tidoust added a commit that referenced this issue Dec 9, 2024
Close #1378.

This also drops the CSS patch for css-values-5, no longer needed.

I still don't fully grasp why dependabot did not propose the bump but I suspect
that is due to the fact that we also have css-tree as a peer dependency for the
`@webref/css` package (which is also a dependency for testing purpose)
tidoust added a commit that referenced this issue Dec 9, 2024
Close #1378.

This also drops the CSS patch for css-values-5, no longer needed.

I still don't fully grasp why dependabot did not propose the bump but I suspect
that is due to the fact that we also have css-tree as a peer dependency for the
`@webref/css` package (which is also a dependency for testing purpose)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants