Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API doesn't work in npm3 / node5 / mac #5

Closed
justinbmeyer opened this issue Jan 6, 2016 · 5 comments
Closed

API doesn't work in npm3 / node5 / mac #5

justinbmeyer opened this issue Jan 6, 2016 · 5 comments
Assignees

Comments

@justinbmeyer
Copy link

After running: donejs api

> [email protected] api /Users/justin/dev/temp/place-my-order
> place-my-order-api --port 7070

App listening at http://:::7070
Dropped database
Created restaurant Cheese Curd City(32fXaRLXCJeSPowy)
/Users/justin/dev/temp/place-my-order/node_modules/feathers-commons/lib/sockets/helpers.js:55
      info.clients().forEach(function (socket) {
                     ^

TypeError: info.clients(...).forEach is not a function
    at Object.<anonymous> (/Users/justin/dev/temp/place-my-order/node_modules/feathers-commons/lib/sockets/helpers.js:55:22)
@daffl
Copy link
Contributor

daffl commented Jan 6, 2016

This is a breaking change in a Socket.io patch release (see socketio/socket.io#2368). A fix for Feathers has been added via feathersjs-ecosystem/commons@858a264 so clearing the cache and reinstalling should solve the issue.

@daffl daffl closed this as completed Jan 6, 2016
@justinbmeyer
Copy link
Author

I cleared my cache yesterday.

Sent from my iPhone

On Jan 6, 2016, at 12:41 AM, David Luecke [email protected] wrote:

This is a breaking change in a Socket.io patch release (see socketio/socket.io#2368). A fix for Feathers has been added via feathersjs-ecosystem/commons@858a264 so clearing the cache and reinstalling should solve the issue.


Reply to this email directly or view it on GitHub.

@daffl
Copy link
Contributor

daffl commented Jan 6, 2016

I just tried what I suggested and I don't get an error. The fix came in about an hour before you submitted the issue. If you try again and it is still happening I can look into it again.

@daffl
Copy link
Contributor

daffl commented Jan 6, 2016

Actually, there may be a wrong version matcher in the API. I'll double check.

@daffl daffl reopened this Jan 6, 2016
@daffl
Copy link
Contributor

daffl commented Jan 6, 2016

Verified. This should be good now.

@daffl daffl closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants