Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components/client-projects #209

Open
1 of 7 tasks
justinbmeyer opened this issue Dec 19, 2016 · 0 comments
Open
1 of 7 tasks

components/client-projects #209

justinbmeyer opened this issue Dec 19, 2016 · 0 comments
Assignees
@ilyavf
Labels
cleanup in progress

Comments

@justinbmeyer
Copy link
Contributor

justinbmeyer commented Dec 19, 2016 •
edited by obaidott
Loading

  • - remove #with contributionMonth.
  • - move methods like commissionedMonthlyOSProjectsCountFor to monthlyClientProject.commissionedCount
    - [ ] - uncommissionedMonthlyOSProjectsCountFor
    - [ ] - toggleUseProject
    - [ ] - getRate
    - [ ] - getTotal
  • - Is value="{{osProjectRef.value.name}}" necessary?
  • - {$disabled}="contributionMonth.isSaving()"
  • - checkboxes can use a converter.
  • - make similar adjustments to make the add client project form work as components/os-projects #207.
  • - is toggleEditMonthlyClientProject used? If not, editingClientProjectIds can also go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilyavf ilyavf

Labels
cleanup in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinbmeyer @ilyavf @obaidott