feat(api): allow token authentication for get_sound and list_sounds
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-kramer
changed the title
get_sound and `list_sound…get_sound and list_sounds
richard-kramer
force-pushed
the
20231229_17_kramer_allow-token-access-to-sounds
branch
from
31c3ed8 to
fd29ee9
Compare
|
Sure, I see no problem with that. Extending the permissions of the API token makes it a bit more worthwhile to look into securing it better (i.e., only allowing it to be downloaded once when it is created and allowing proper management of multiple keys), but that is an issue for another time. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables token authentication for the routes
get_soundandlist_soundsto allow accessing these via API call and e.g. directly use the soundfiles in an external application.Fixes #17