go-rename in go-mode.el conflicts with go-rename in go-rename.el

[gutron]

go-rename.el: (defun go-rename (new-name &optional force)

go-mode.el: (defun go-rename ()

And since go-rename.el requires go-mode.el, go-rename.el no longer compiles cleanly.

[dominikh]

@adonovan are there any plans to deprecate gorename in the same manner as guru?

[adonovan]

(Sorry for neglecting this.)

Sorry for defining the conflicting symbols. We don't have a specific proposal to deprecate and delete cmd/gorename, but we probably should as its core functionality is accessible through gopls:

$ cat a.go
package main

func main() {
	f()
}

func f() {}

$ gopls rename -write ./a.go:#42 g

$ cat a.go
package main

func main() {
	g()
}

func g() {}

(gopls doesn't have support the symbolic command-line syntax, but I'm not sure I expect most people invoke it by position, from their editor.)

[adonovan]

Filed:

• x/tools/cmd/gorename: tag and delete it golang/go#69360