Skip to content

Conversation

@martincostello
Copy link
Collaborator

@martincostello martincostello commented Oct 10, 2025

  • Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation.
  • Use consistent PowerShell environment variable syntax.
  • Update NuGet package tags to include OpenAPI and/or swagger-ui.
  • Add missing NuGet package tags.
  • Add missing XML documentation.
  • Add missing source revision to the Swashbuckle.AspNetCore metapackage.

- Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation.
- Use consistent PowerShell environment variable syntax.
@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (b00b493) to head (0c52504).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3602   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files         110      110           
  Lines        3816     3816           
  Branches      723      723           
=======================================
  Hits         3598     3598           
  Misses        218      218           
Flag Coverage Δ
Linux 94.28% <ø> (ø)
Windows 94.28% <ø> (ø)
macOS 94.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add `openapi`.
- Add missing tags for Swashbuckle.AspNetCore.Cli.
- Add tags for swagger-ui.
Add XML documentation for the Swashbuckle.AspNetCore.Newtonsoft package.
Add the Git commit SHA to the `.nuspec` for Swashbuckle.AspNetCore.
@martincostello martincostello added this to the v9.0.7 milestone Oct 10, 2025
@martincostello martincostello marked this pull request as ready for review October 10, 2025 10:02
Copilot AI review requested due to automatic review settings October 10, 2025 10:02
@martincostello martincostello merged commit 58c5095 into master Oct 10, 2025
14 checks passed
@martincostello martincostello deleted the extend-package-validation branch October 10, 2025 10:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends NuGet package validation capabilities and improves packaging metadata for the Swashbuckle.AspNetCore project. It integrates a new validation tool, standardizes PowerShell environment variable syntax, and enhances package discoverability through improved tagging.

  • Adds Meziantou.Framework.NuGetPackageValidation.Tool for enhanced NuGet package validation
  • Updates PowerShell environment variable syntax to use consistent ${env:VAR} format across all files
  • Enhances NuGet package tags by adding "openapi" and "swagger-ui" tags where relevant

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Swashbuckle.AspNetCore/Swashbuckle.AspNetCore.nuspec Adds repository commit metadata to the metapackage
src/Swashbuckle.AspNetCore/Swashbuckle.AspNetCore.csproj Updates package tags and adds repository commit property
src/Swashbuckle.AspNetCore.SwaggerUI/Swashbuckle.AspNetCore.SwaggerUI.csproj Adds swagger-ui specific tags to improve discoverability
src/Swashbuckle.AspNetCore.SwaggerGen/Swashbuckle.AspNetCore.SwaggerGen.csproj Adds openapi tag to package metadata
src/Swashbuckle.AspNetCore.Swagger/Swashbuckle.AspNetCore.Swagger.csproj Adds openapi tag to package metadata
src/Swashbuckle.AspNetCore.ReDoc/Swashbuckle.AspNetCore.ReDoc.csproj Adds openapi tag to package metadata
src/Swashbuckle.AspNetCore.Newtonsoft/Swashbuckle.AspNetCore.Newtonsoft.csproj Enables XML documentation generation and adds openapi tag
src/Swashbuckle.AspNetCore.Newtonsoft/SchemaGenerator/NewtonsoftDataContractResolver.cs Adds comprehensive XML documentation for class and methods
src/Swashbuckle.AspNetCore.Newtonsoft/SchemaGenerator/JsonPropertyExtensions.cs Adds comprehensive XML documentation for extension methods
src/Swashbuckle.AspNetCore.Newtonsoft/DependencyInjection/NewtonsoftServiceCollectionExtensions.cs Adds comprehensive XML documentation for extension methods
src/Swashbuckle.AspNetCore.Cli/Swashbuckle.AspNetCore.Cli.csproj Adds package tags for CLI tool including commandline tag
src/Swashbuckle.AspNetCore.Annotations/Swashbuckle.AspNetCore.Annotations.csproj Adds openapi tag to package metadata
build.ps1 Updates PowerShell environment variable syntax for consistency
.github/workflows/release.yml Updates PowerShell environment variable syntax for consistency
.github/workflows/bump-version.yml Updates PowerShell environment variable syntax for consistency
.github/workflows/build.yml Integrates new NuGet package validation tool and updates environment variable syntax
.github/bump-version.ps1 Updates PowerShell environment variable syntax for consistency
.config/dotnet-tools.json Adds Meziantou.Framework.NuGetPackageValidation.Tool and sets rollForward to false for all tools

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This was referenced Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants