-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Extend NuGet package validation #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use Meziantou.Framework.NuGetPackageValidation.Tool to extend NuGet package validation. - Use consistent PowerShell environment variable syntax.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3602 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 110 110
Lines 3816 3816
Branches 723 723
=======================================
Hits 3598 3598
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add `openapi`. - Add missing tags for Swashbuckle.AspNetCore.Cli. - Add tags for swagger-ui.
Add XML documentation for the Swashbuckle.AspNetCore.Newtonsoft package.
Add the Git commit SHA to the `.nuspec` for Swashbuckle.AspNetCore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends NuGet package validation capabilities and improves packaging metadata for the Swashbuckle.AspNetCore project. It integrates a new validation tool, standardizes PowerShell environment variable syntax, and enhances package discoverability through improved tagging.
- Adds Meziantou.Framework.NuGetPackageValidation.Tool for enhanced NuGet package validation
- Updates PowerShell environment variable syntax to use consistent
${env:VAR}format across all files - Enhances NuGet package tags by adding "openapi" and "swagger-ui" tags where relevant
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Swashbuckle.AspNetCore/Swashbuckle.AspNetCore.nuspec | Adds repository commit metadata to the metapackage |
| src/Swashbuckle.AspNetCore/Swashbuckle.AspNetCore.csproj | Updates package tags and adds repository commit property |
| src/Swashbuckle.AspNetCore.SwaggerUI/Swashbuckle.AspNetCore.SwaggerUI.csproj | Adds swagger-ui specific tags to improve discoverability |
| src/Swashbuckle.AspNetCore.SwaggerGen/Swashbuckle.AspNetCore.SwaggerGen.csproj | Adds openapi tag to package metadata |
| src/Swashbuckle.AspNetCore.Swagger/Swashbuckle.AspNetCore.Swagger.csproj | Adds openapi tag to package metadata |
| src/Swashbuckle.AspNetCore.ReDoc/Swashbuckle.AspNetCore.ReDoc.csproj | Adds openapi tag to package metadata |
| src/Swashbuckle.AspNetCore.Newtonsoft/Swashbuckle.AspNetCore.Newtonsoft.csproj | Enables XML documentation generation and adds openapi tag |
| src/Swashbuckle.AspNetCore.Newtonsoft/SchemaGenerator/NewtonsoftDataContractResolver.cs | Adds comprehensive XML documentation for class and methods |
| src/Swashbuckle.AspNetCore.Newtonsoft/SchemaGenerator/JsonPropertyExtensions.cs | Adds comprehensive XML documentation for extension methods |
| src/Swashbuckle.AspNetCore.Newtonsoft/DependencyInjection/NewtonsoftServiceCollectionExtensions.cs | Adds comprehensive XML documentation for extension methods |
| src/Swashbuckle.AspNetCore.Cli/Swashbuckle.AspNetCore.Cli.csproj | Adds package tags for CLI tool including commandline tag |
| src/Swashbuckle.AspNetCore.Annotations/Swashbuckle.AspNetCore.Annotations.csproj | Adds openapi tag to package metadata |
| build.ps1 | Updates PowerShell environment variable syntax for consistency |
| .github/workflows/release.yml | Updates PowerShell environment variable syntax for consistency |
| .github/workflows/bump-version.yml | Updates PowerShell environment variable syntax for consistency |
| .github/workflows/build.yml | Integrates new NuGet package validation tool and updates environment variable syntax |
| .github/bump-version.ps1 | Updates PowerShell environment variable syntax for consistency |
| .config/dotnet-tools.json | Adds Meziantou.Framework.NuGetPackageValidation.Tool and sets rollForward to false for all tools |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.