From 3d308921719bae7d4f04433522323a5db39fbdcd Mon Sep 17 00:00:00 2001 From: angelamayxie Date: Fri, 2 Jan 2026 12:57:37 -0800 Subject: [PATCH 1/3] add test --- enginetest/queries/script_queries.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/enginetest/queries/script_queries.go b/enginetest/queries/script_queries.go index 83fb585946..e640fde463 100644 --- a/enginetest/queries/script_queries.go +++ b/enginetest/queries/script_queries.go @@ -14657,6 +14657,20 @@ select * from t1 except ( }, }, }, + { + // https://github.com/dolthub/dolt/issues/10246 + Name: "boolean keys are not used for string column lookups", + SetUpScript: []string{ + "create table t1(c0 varchar(500), primary key(c0))", + "insert into t1(c0) values ('')", + }, + Assertions: []ScriptTestAssertion{ + { + Query: "select 1 from t1 where false=t1.c0", + Expected: []sql.Row{{1}}, + }, + }, + }, } var SpatialScriptTests = []ScriptTest{ From ee755789ea491aef7cf0f5b6ac77102923d7a6cc Mon Sep 17 00:00:00 2001 From: angelamayxie Date: Fri, 2 Jan 2026 13:50:43 -0800 Subject: [PATCH 2/3] add mysql dialect tag --- enginetest/queries/script_queries.go | 1 + 1 file changed, 1 insertion(+) diff --git a/enginetest/queries/script_queries.go b/enginetest/queries/script_queries.go index e640fde463..2fed72b73e 100644 --- a/enginetest/queries/script_queries.go +++ b/enginetest/queries/script_queries.go @@ -14659,6 +14659,7 @@ select * from t1 except ( }, { // https://github.com/dolthub/dolt/issues/10246 + Dialect: "mysql", Name: "boolean keys are not used for string column lookups", SetUpScript: []string{ "create table t1(c0 varchar(500), primary key(c0))", From 89e68986aee25fcef1a93b61cf2edffb7fd8557f Mon Sep 17 00:00:00 2001 From: angelamayxie Date: Fri, 2 Jan 2026 21:52:03 +0000 Subject: [PATCH 3/3] [ga-format-pr] Run ./format_repo.sh to fix formatting --- enginetest/queries/script_queries.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enginetest/queries/script_queries.go b/enginetest/queries/script_queries.go index 2fed72b73e..f4c7987e77 100644 --- a/enginetest/queries/script_queries.go +++ b/enginetest/queries/script_queries.go @@ -14660,7 +14660,7 @@ select * from t1 except ( { // https://github.com/dolthub/dolt/issues/10246 Dialect: "mysql", - Name: "boolean keys are not used for string column lookups", + Name: "boolean keys are not used for string column lookups", SetUpScript: []string{ "create table t1(c0 varchar(500), primary key(c0))", "insert into t1(c0) values ('')",