From 60dd47fe3b9a2f54920953499168de337d161ee3 Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 4 Feb 2026 12:57:58 -0800 Subject: [PATCH 1/5] add constraint_column_usage view --- go.mod | 8 +-- go.sum | 12 ++-- server/functions/regtype.go | 3 + server/functions/setval.go | 3 +- server/hook/delete_table.go | 2 +- .../constraint_column_usage_view.go | 72 +++++++++++++++++++ server/tables/information_schema/init.go | 10 +++ server/tables/pgcatalog/pg_class.go | 47 ++++++------ testing/go/functions_test.go | 11 +++ 9 files changed, 131 insertions(+), 37 deletions(-) create mode 100644 server/tables/information_schema/constraint_column_usage_view.go diff --git a/go.mod b/go.mod index 5063bb3652..02e62a29fc 100644 --- a/go.mod +++ b/go.mod @@ -1,18 +1,18 @@ module github.com/dolthub/doltgresql -go 1.25.3 +go 1.25.6 require ( github.com/PuerkitoBio/goquery v1.8.1 github.com/cockroachdb/apd/v2 v2.0.3-0.20200518165714-d020e156310a github.com/cockroachdb/errors v1.7.5 - github.com/dolthub/dolt/go v0.40.5-0.20260122084121-6b5d5373d1ec + github.com/dolthub/dolt/go v0.40.5-0.20260204203432-e5e813c0a754 github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 - github.com/dolthub/go-mysql-server v0.20.1-0.20260121234050-2f0507726303 + github.com/dolthub/go-mysql-server v0.20.1-0.20260204201213-2a60c7ddeaa2 github.com/dolthub/pg_query_go/v6 v6.0.0-20251215122834-fb20be4254d1 github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216 - github.com/dolthub/vitess v0.0.0-20260121194826-a5ce52b608e4 + github.com/dolthub/vitess v0.0.0-20260202234501-b14ed9b1632b github.com/fatih/color v1.13.0 github.com/goccy/go-json v0.10.2 github.com/gogo/protobuf v1.3.2 diff --git a/go.sum b/go.sum index 1c000732f5..a72047b8bd 100644 --- a/go.sum +++ b/go.sum @@ -228,8 +228,8 @@ github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 h1:I github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12/go.mod h1:rN7X8BHwkjPcfMQQ2QTAq/xM3leUSGLfb+1Js7Y6TVo= github.com/dolthub/dolt-mcp v0.2.2 h1:bpROmam74n95uU4EA3BpOIVlTDT0pzeFMBwe/YRq2mI= github.com/dolthub/dolt-mcp v0.2.2/go.mod h1:S++DJ4QWTAXq+0TNzFa7Oq3IhoT456DJHwAINFAHgDQ= -github.com/dolthub/dolt/go v0.40.5-0.20260122084121-6b5d5373d1ec h1:IzUyIbG7oX3Je53nxq0ZNrsp3C9n2THmiWMJHA9KeDo= -github.com/dolthub/dolt/go v0.40.5-0.20260122084121-6b5d5373d1ec/go.mod h1:UUKnXBHOBTr5CzxFLOZ/9Pm0O+F4ZArKRxs5kUMpXH8= +github.com/dolthub/dolt/go v0.40.5-0.20260204203432-e5e813c0a754 h1:3Hv9KIKCxMurBCG0k/CEIGxsPRvEuqMaW7xPh32z9/Q= +github.com/dolthub/dolt/go v0.40.5-0.20260204203432-e5e813c0a754/go.mod h1:fW45BByc7xPVM9eORuL2be6+WAlFwHvdtLICFcTOm4w= github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca h1:BGFz/0OlKIuC6qHIZQbvPapFvdAJkeEyGXWVgL5clmE= github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca/go.mod h1:CoDLfgPqHyBtth0Cp+fi/CmC4R81zJNX4wPjShdZ+Bw= github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 h1:u3PMzfF8RkKd3lB9pZ2bfn0qEG+1Gms9599cr0REMww= @@ -238,8 +238,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U= github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0= github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790 h1:zxMsH7RLiG+dlZ/y0LgJHTV26XoiSJcuWq+em6t6VVc= github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE= -github.com/dolthub/go-mysql-server v0.20.1-0.20260121234050-2f0507726303 h1:O4s+FF9G1Jv7uRnR/bB9jTzvPfvnZbcZOZMa3cip8d4= -github.com/dolthub/go-mysql-server v0.20.1-0.20260121234050-2f0507726303/go.mod h1:7L2EdzgWLnS7blMNuF+67RTZVMhRLyKQv36mZcjU8u8= +github.com/dolthub/go-mysql-server v0.20.1-0.20260204201213-2a60c7ddeaa2 h1:SJvZgTAzdnThnAqM94MUqLvAxdqVQeRK/ariplpvdcg= +github.com/dolthub/go-mysql-server v0.20.1-0.20260204201213-2a60c7ddeaa2/go.mod h1:LEWdXw6LKjdonOv2X808RpUc8wZVtQx4ZEPvmDWkvY4= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI= github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q= github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE= @@ -250,8 +250,8 @@ github.com/dolthub/pg_query_go/v6 v6.0.0-20251215122834-fb20be4254d1 h1:GY17cGA4 github.com/dolthub/pg_query_go/v6 v6.0.0-20251215122834-fb20be4254d1/go.mod h1:qnrZP3/1slFl2Bq5yw38HLOsArZareGwdpEceriblLc= github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216 h1:JWkKRE4EHUcEVQCMRBej8DYxjYjRz/9MdF/NNQh0o70= github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216/go.mod h1:e/FIZVvT2IR53HBCAo41NjqgtEnjMJGKca3Y/dAmZaA= -github.com/dolthub/vitess v0.0.0-20260121194826-a5ce52b608e4 h1:isOZRx9OfOdwZ4UmeYrS+UYiiu02e8taNJLAuqZjfcQ= -github.com/dolthub/vitess v0.0.0-20260121194826-a5ce52b608e4/go.mod h1:FLWqdXsAeeBQyFwDjmBVu0GnbjI2MKeRf3tRVdJEKlI= +github.com/dolthub/vitess v0.0.0-20260202234501-b14ed9b1632b h1:B8QS0U5EHtJTiOptjti1cH/OiE6uczyhePtvVFigf3w= +github.com/dolthub/vitess v0.0.0-20260202234501-b14ed9b1632b/go.mod h1:eLLslh1CSPMf89pPcaMG4yM72PQbTN9OUYJeAy0fAis= github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk= github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY= github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto= diff --git a/server/functions/regtype.go b/server/functions/regtype.go index 28b1a7f6f8..ab1074a460 100644 --- a/server/functions/regtype.go +++ b/server/functions/regtype.go @@ -80,6 +80,9 @@ var regtypein = framework.Function1{ if typeName == "char" && schema == "" { return id.NewType("pg_catalog", "bpchar").AsId(), nil } + if typeName == "int" { + typeName = "int4" + } if internalID, ok := pgtypes.NameToInternalID[typeName]; ok && (internalID.SchemaName() == schema || schema == "") { return internalID.AsId(), nil } diff --git a/server/functions/setval.go b/server/functions/setval.go index f5ca0f232e..bb871c1aad 100644 --- a/server/functions/setval.go +++ b/server/functions/setval.go @@ -89,7 +89,8 @@ func parseRelationName(ctx *sql.Context, name string) (schema string, relation s return "", "", errors.Errorf(`cannot parse relation: %s`, name) } - // Trim any quotes from the relation name + // Trim any quotes from the schema and the relation name + schema = strings.Trim(schema, `"`) relation = strings.Trim(relation, `"`) return schema, relation, nil diff --git a/server/hook/delete_table.go b/server/hook/delete_table.go index ad2f4a8efc..9bd50ac3e0 100644 --- a/server/hook/delete_table.go +++ b/server/hook/delete_table.go @@ -30,7 +30,7 @@ import ( // BeforeTableDeletion performs all validation necessary to ensure that table deletion does not leave the database in an // invalid state. -func BeforeTableDeletion(ctx *sql.Context, nodeInterface sql.Node) (sql.Node, error) { +func BeforeTableDeletion(ctx *sql.Context, sr sql.StatementRunner, nodeInterface sql.Node) (sql.Node, error) { n, ok := nodeInterface.(*plan.DropTable) if !ok { return nil, errors.Newf("DROP TABLE pre-hook expected `*plan.DropTable` but received `%T`", nodeInterface) diff --git a/server/tables/information_schema/constraint_column_usage_view.go b/server/tables/information_schema/constraint_column_usage_view.go new file mode 100644 index 0000000000..90cb8468ce --- /dev/null +++ b/server/tables/information_schema/constraint_column_usage_view.go @@ -0,0 +1,72 @@ +// Copyright 2026 Dolthub, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package information_schema + +import ( + "github.com/dolthub/go-mysql-server/sql" + "github.com/dolthub/go-mysql-server/sql/information_schema" + + "github.com/dolthub/doltgresql/server/functions" +) + +// ConstraintColumnUsageViewName is the name of the CONSTRAINT_COLUMN_USAGE view. +const ConstraintColumnUsageViewName = "constraint_column_usage" + +// newConstraintColumnUsageView creates a new information_schema.CONSTRAINT_COLUMN_USAGE view. +func newConstraintColumnUsageView() *information_schema.InformationSchemaTable { + return &information_schema.InformationSchemaTable{ + TableName: ConstraintColumnUsageViewName, + TableSchema: viewsSchema, + Reader: viewsRowIter, + } +} + +// constraintColumnUsage is the schema for the information_schema.CONSTRAINT_COLUMN_USAGE view. +var constraintColumnUsageSchema = sql.Schema{ + {Name: "table_catalog", Type: sql_identifier, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "table_schema", Type: sql_identifier, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "table_name", Type: sql_identifier, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "column_name", Type: character_data, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "constraint_catalog", Type: character_data, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "constraint_schema", Type: yes_or_no, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, + {Name: "constraint_name", Type: yes_or_no, Default: nil, Nullable: true, Source: ConstraintColumnUsageViewName}, +} + +// constraintColumnUsageRowIter implements the sql.RowIter for the information_schema.CONSTRAINT_COLUMN_USAGE view. +func constraintColumnUsageRowIter(ctx *sql.Context, catalog sql.Catalog) (sql.RowIter, error) { + var rows []sql.Row + + err := functions.IterateCurrentDatabase(ctx, functions.Callbacks{ + Check: func(ctx *sql.Context, schema functions.ItemSchema, table functions.ItemTable, check functions.ItemCheck) (cont bool, err error) { + + // TODO: Fill out the rest of the columns. + rows = append(rows, sql.Row{ + schema.Item.Name(), // table_catalog + schema.Item.SchemaName(), // table_schema + table.Item.Name(), // table_name + nil, // column_name + nil, // constraint_catalog + nil, // constraint_schema + check.Item.Name, // constraint_name + }) + return true, nil + }, + }) + if err != nil { + return nil, err + } + + return sql.RowsToRowIter(rows...), nil +} diff --git a/server/tables/information_schema/init.go b/server/tables/information_schema/init.go index 44587022ec..ed9d6efa7d 100644 --- a/server/tables/information_schema/init.go +++ b/server/tables/information_schema/init.go @@ -15,6 +15,7 @@ package information_schema import ( + "github.com/dolthub/go-mysql-server/sql" "github.com/dolthub/go-mysql-server/sql/information_schema" ) @@ -25,4 +26,13 @@ func Init() { information_schema.NewSchemataTable = newSchemataTable information_schema.NewTablesTable = newTablesTable information_schema.NewViewsTable = newViewsTable + + // Postgres-specific tables/views to be added to information_schema database + information_schema.NewInformationSchemaTablesToAdd = map[string]sql.Table{ + ConstraintColumnUsageViewName: &information_schema.InformationSchemaTable{ + TableName: ConstraintColumnUsageViewName, + TableSchema: constraintColumnUsageSchema, + Reader: constraintColumnUsageRowIter, + }, + } } diff --git a/server/tables/pgcatalog/pg_class.go b/server/tables/pgcatalog/pg_class.go index 85854118c9..b2dd7738ce 100644 --- a/server/tables/pgcatalog/pg_class.go +++ b/server/tables/pgcatalog/pg_class.go @@ -16,13 +16,10 @@ package pgcatalog import ( "fmt" + "github.com/dolthub/go-mysql-server/sql" "io" "math" - "github.com/dolthub/dolt/go/libraries/doltcore/sqle/resolve" - "github.com/dolthub/go-mysql-server/sql" - - "github.com/dolthub/doltgresql/core" "github.com/dolthub/doltgresql/core/id" "github.com/dolthub/doltgresql/server/functions" "github.com/dolthub/doltgresql/server/tables" @@ -155,27 +152,27 @@ func cachePgClasses(ctx *sql.Context, pgCatalogCache *pgCatalogCache) error { } if includeSystemTables { - _, root, err := core.GetRootFromContext(ctx) - if err != nil { - return err - } - - systemTables, err := resolve.GetGeneratedSystemTables(ctx, root) - if err != nil { - return err - } - - for _, tblName := range systemTables { - class := &pgClass{ - oid: id.NewTable(tblName.Schema, tblName.Name).AsId(), - name: tblName.Name, - schemaOid: id.NewNamespace(tblName.Schema).AsId(), - kind: "r", - } - nameIdx.Add(class) - oidIdx.Add(class) - classes = append(classes, class) - } + //_, root, err := core.GetRootFromContext(ctx) + //if err != nil { + // return err + //} + // + //systemTables, err := resolve.GetGeneratedSystemTables(ctx, root) + //if err != nil { + // return err + //} + // + //for _, tblName := range systemTables { + // class := &pgClass{ + // oid: id.NewTable(tblName.Schema, tblName.Name).AsId(), + // name: tblName.Name, + // schemaOid: id.NewNamespace(tblName.Schema).AsId(), + // kind: "r", + // } + // nameIdx.Add(class) + // oidIdx.Add(class) + // classes = append(classes, class) + //} } pgCatalogCache.pgClasses = &pgClassCache{ diff --git a/testing/go/functions_test.go b/testing/go/functions_test.go index e2e6ee02c9..6c5b326bfd 100644 --- a/testing/go/functions_test.go +++ b/testing/go/functions_test.go @@ -780,6 +780,12 @@ func TestFunctionsOID(t *testing.T) { {"integer"}, }, }, + { + Query: `SELECT to_regtype(('int'::regtype)::text);`, + Expected: []sql.Row{ + {"integer"}, + }, + }, { Query: `SELECT to_regtype((('integer'::regtype)::oid)::text);`, Expected: []sql.Row{ @@ -1393,6 +1399,11 @@ func TestSystemInformationFunctions(t *testing.T) { ExpectedColNames: []string{"pg_get_serial_sequence"}, Expected: []sql.Row{{"public.t1_id_seq"}}, }, + { + Query: `SELECT pg_get_serial_sequence('"public"."t1"', 'id');`, + ExpectedColNames: []string{"pg_get_serial_sequence"}, + Expected: []sql.Row{{"public.t1_id_seq"}}, + }, { // Test with no schema specified Query: `SELECT pg_get_serial_sequence('t1', 'id');`, From 7950151e968984af23e9d8d0e5099cca72b98dd3 Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 4 Feb 2026 13:16:57 -0800 Subject: [PATCH 2/5] add skipped test for ROLLBACK --- testing/go/session_test.go | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/testing/go/session_test.go b/testing/go/session_test.go index 31096ce742..fab9ee1e3b 100755 --- a/testing/go/session_test.go +++ b/testing/go/session_test.go @@ -69,3 +69,36 @@ func TestDiscard(t *testing.T) { }, }) } + +func TestRollback(t *testing.T) { + RunScripts(t, []ScriptTest{ + { + Name: "Test rollback transaction", + SetUpScript: []string{ + `BEGIN`, + `CREATE temporary TABLE test (a INT)`, + `insert into test values (1)`, + }, + Assertions: []ScriptTestAssertion{ + { + Query: "select * from test", + Expected: []sql.Row{{1}}, + }, + { + Query: "ROLLBACK", + Expected: []sql.Row{}, + }, + { + Query: "select * from test", + ExpectedErr: "table not found", + Skip: true, // temp table should be dropped after ROLLBACK + }, + { + Query: "create temp table test (b int)", + Expected: []sql.Row{}, + Skip: true, // temp table should be dropped after ROLLBACK + }, + }, + }, + }) +} From 41678b57e85ea7059052ba49f4e9062968a878e2 Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 4 Feb 2026 13:23:37 -0800 Subject: [PATCH 3/5] format --- server/tables/pgcatalog/pg_class.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/tables/pgcatalog/pg_class.go b/server/tables/pgcatalog/pg_class.go index b2dd7738ce..fb714ade8a 100644 --- a/server/tables/pgcatalog/pg_class.go +++ b/server/tables/pgcatalog/pg_class.go @@ -16,10 +16,11 @@ package pgcatalog import ( "fmt" - "github.com/dolthub/go-mysql-server/sql" "io" "math" + "github.com/dolthub/go-mysql-server/sql" + "github.com/dolthub/doltgresql/core/id" "github.com/dolthub/doltgresql/server/functions" "github.com/dolthub/doltgresql/server/tables" From 3051fc64b78c4f2b1063b53466a844fed4254d46 Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 4 Feb 2026 13:30:04 -0800 Subject: [PATCH 4/5] static check --- .../constraint_column_usage_view.go | 4 +- server/tables/information_schema/init.go | 6 +-- server/tables/pgcatalog/pg_class.go | 44 ++++++++++--------- 3 files changed, 26 insertions(+), 28 deletions(-) diff --git a/server/tables/information_schema/constraint_column_usage_view.go b/server/tables/information_schema/constraint_column_usage_view.go index 90cb8468ce..caa9bca867 100644 --- a/server/tables/information_schema/constraint_column_usage_view.go +++ b/server/tables/information_schema/constraint_column_usage_view.go @@ -28,8 +28,8 @@ const ConstraintColumnUsageViewName = "constraint_column_usage" func newConstraintColumnUsageView() *information_schema.InformationSchemaTable { return &information_schema.InformationSchemaTable{ TableName: ConstraintColumnUsageViewName, - TableSchema: viewsSchema, - Reader: viewsRowIter, + TableSchema: constraintColumnUsageSchema, + Reader: constraintColumnUsageRowIter, } } diff --git a/server/tables/information_schema/init.go b/server/tables/information_schema/init.go index ed9d6efa7d..41b94dd7e0 100644 --- a/server/tables/information_schema/init.go +++ b/server/tables/information_schema/init.go @@ -29,10 +29,6 @@ func Init() { // Postgres-specific tables/views to be added to information_schema database information_schema.NewInformationSchemaTablesToAdd = map[string]sql.Table{ - ConstraintColumnUsageViewName: &information_schema.InformationSchemaTable{ - TableName: ConstraintColumnUsageViewName, - TableSchema: constraintColumnUsageSchema, - Reader: constraintColumnUsageRowIter, - }, + ConstraintColumnUsageViewName: newConstraintColumnUsageView(), } } diff --git a/server/tables/pgcatalog/pg_class.go b/server/tables/pgcatalog/pg_class.go index fb714ade8a..85854118c9 100644 --- a/server/tables/pgcatalog/pg_class.go +++ b/server/tables/pgcatalog/pg_class.go @@ -19,8 +19,10 @@ import ( "io" "math" + "github.com/dolthub/dolt/go/libraries/doltcore/sqle/resolve" "github.com/dolthub/go-mysql-server/sql" + "github.com/dolthub/doltgresql/core" "github.com/dolthub/doltgresql/core/id" "github.com/dolthub/doltgresql/server/functions" "github.com/dolthub/doltgresql/server/tables" @@ -153,27 +155,27 @@ func cachePgClasses(ctx *sql.Context, pgCatalogCache *pgCatalogCache) error { } if includeSystemTables { - //_, root, err := core.GetRootFromContext(ctx) - //if err != nil { - // return err - //} - // - //systemTables, err := resolve.GetGeneratedSystemTables(ctx, root) - //if err != nil { - // return err - //} - // - //for _, tblName := range systemTables { - // class := &pgClass{ - // oid: id.NewTable(tblName.Schema, tblName.Name).AsId(), - // name: tblName.Name, - // schemaOid: id.NewNamespace(tblName.Schema).AsId(), - // kind: "r", - // } - // nameIdx.Add(class) - // oidIdx.Add(class) - // classes = append(classes, class) - //} + _, root, err := core.GetRootFromContext(ctx) + if err != nil { + return err + } + + systemTables, err := resolve.GetGeneratedSystemTables(ctx, root) + if err != nil { + return err + } + + for _, tblName := range systemTables { + class := &pgClass{ + oid: id.NewTable(tblName.Schema, tblName.Name).AsId(), + name: tblName.Name, + schemaOid: id.NewNamespace(tblName.Schema).AsId(), + kind: "r", + } + nameIdx.Add(class) + oidIdx.Add(class) + classes = append(classes, class) + } } pgCatalogCache.pgClasses = &pgClassCache{ From 7b99198fb4c5acc42095a0b27cb882bc2a6b93ed Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 4 Feb 2026 14:50:22 -0800 Subject: [PATCH 5/5] skip dolt engine test as it uses foreign_key_checks system variable --- testing/go/enginetest/doltgres_engine_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/testing/go/enginetest/doltgres_engine_test.go b/testing/go/enginetest/doltgres_engine_test.go index be09583680..d3439c902c 100755 --- a/testing/go/enginetest/doltgres_engine_test.go +++ b/testing/go/enginetest/doltgres_engine_test.go @@ -1687,6 +1687,7 @@ func TestDoltCommit(t *testing.T) { "CALL DOLT_COMMIT('-amend') works to remove changes from a commit", "CALL DOLT_COMMIT('-amend') works to update a merge commit", "CALL DOLT_COMMIT('--amend') works on initial commit", + "DOLT_COMMIT respects foreign_key_checks=0", }) denginetest.RunDoltCommitTests(t, harness) }