From 4e3897318494cfbec1923f32577a45a4cb915930 Mon Sep 17 00:00:00 2001 From: James Cor Date: Mon, 29 Jan 2024 13:40:29 -0800 Subject: [PATCH 1/6] fix sqllogictest harness to truncate instead of round --- go/libraries/doltcore/sqle/logictest/dolt/doltharness.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go index 50f27287103..78a22859cbb 100644 --- a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go +++ b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go @@ -225,7 +225,7 @@ func toSqlString(val interface{}) string { return fmt.Sprintf("%.3f", v) case decimal.Decimal: // exactly 3 decimal points for floats - return v.StringFixed(3) + return v.Truncate(3).String() case int: return strconv.Itoa(v) case uint: From f2c4b11a6701b899717a3822080ca4aa4d4bc3bd Mon Sep 17 00:00:00 2001 From: coffeegoddd Date: Mon, 29 Jan 2024 22:06:22 +0000 Subject: [PATCH 2/6] [skip actions] [ga-update-correctness] SQL Correctness updated to 99.998602 --- .github/scripts/sql-correctness/current_correctness.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/sql-correctness/current_correctness.txt b/.github/scripts/sql-correctness/current_correctness.txt index 863793a6282..9f1a9413cb6 100644 --- a/.github/scripts/sql-correctness/current_correctness.txt +++ b/.github/scripts/sql-correctness/current_correctness.txt @@ -1 +1 @@ -99.998653 +99.998602 From 7b40120c816346393c37342436297b29e8706ced Mon Sep 17 00:00:00 2001 From: James Cor Date: Mon, 29 Jan 2024 15:46:08 -0800 Subject: [PATCH 3/6] they round > .5 not >= .5 --- go/libraries/doltcore/sqle/logictest/dolt/doltharness.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go index 78a22859cbb..110a27fd8ff 100644 --- a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go +++ b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go @@ -225,7 +225,7 @@ func toSqlString(val interface{}) string { return fmt.Sprintf("%.3f", v) case decimal.Decimal: // exactly 3 decimal points for floats - return v.Truncate(3).String() + return v.Sub(decimal.NewFromFloat(0.0001)).StringFixed(3) case int: return strconv.Itoa(v) case uint: From 0e933ab64e0f56f95ba34edfa56642849faf8468 Mon Sep 17 00:00:00 2001 From: James Cor Date: Mon, 29 Jan 2024 16:48:10 -0800 Subject: [PATCH 4/6] use ieee float rounding --- go/libraries/doltcore/sqle/logictest/dolt/doltharness.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go index 110a27fd8ff..3004f9ba3e8 100644 --- a/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go +++ b/go/libraries/doltcore/sqle/logictest/dolt/doltharness.go @@ -225,7 +225,8 @@ func toSqlString(val interface{}) string { return fmt.Sprintf("%.3f", v) case decimal.Decimal: // exactly 3 decimal points for floats - return v.Sub(decimal.NewFromFloat(0.0001)).StringFixed(3) + res, _ := v.Float64() + return fmt.Sprintf("%.3f", res) case int: return strconv.Itoa(v) case uint: From 579156b1a0cdf8ee8fdbc8cc72c0eedff438e7ca Mon Sep 17 00:00:00 2001 From: coffeegoddd Date: Tue, 30 Jan 2024 01:15:35 +0000 Subject: [PATCH 5/6] [skip actions] [ga-update-correctness] SQL Correctness updated to 99.998771 --- .github/scripts/sql-correctness/current_correctness.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/sql-correctness/current_correctness.txt b/.github/scripts/sql-correctness/current_correctness.txt index 9f1a9413cb6..a59dc28542d 100644 --- a/.github/scripts/sql-correctness/current_correctness.txt +++ b/.github/scripts/sql-correctness/current_correctness.txt @@ -1 +1 @@ -99.998602 +99.998771 From 05ee1dfeb74881caec4bf14f42d55501e0e36a08 Mon Sep 17 00:00:00 2001 From: coffeegoddd Date: Tue, 30 Jan 2024 20:32:58 +0000 Subject: [PATCH 6/6] [skip actions] [ga-update-correctness] SQL Correctness updated to 99.998787 --- .github/scripts/sql-correctness/current_correctness.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/sql-correctness/current_correctness.txt b/.github/scripts/sql-correctness/current_correctness.txt index f295121c0af..7b073f0d461 100644 --- a/.github/scripts/sql-correctness/current_correctness.txt +++ b/.github/scripts/sql-correctness/current_correctness.txt @@ -1 +1 @@ -99.998669 +99.998787