Remove special support for FunctionalInterrupt from core interrupt handling:

- VIP treatment in general attach/detach/handling looks untidy:
  extern symbols without matching header include but copy&paste
  special under-the-hood c++ delete support, where everyone else has to do their own
  resource tracking as usual.
- FunctionalInterrupt is not used by anything inside core ESP32 Arduino for 8 months now,
  it can be a library, which reduces precious core size for everyone else.

This reverts commit ea61563.

Author: dok-net

CMakeLists.txt

@@ -19,7 +19,6 @@ set(CORE_SRCS
   cores/esp32/esp32-hal-uart.c
   cores/esp32/esp32-hal-rmt.c
   cores/esp32/Esp.cpp
-  cores/esp32/FunctionalInterrupt.cpp
   cores/esp32/HardwareSerial.cpp
   cores/esp32/IPAddress.cpp
   cores/esp32/IPv6Address.cpp

cores/esp32/esp32-hal-gpio.c

@@ -74,7 +74,6 @@ typedef void (*voidFuncPtrArg)(void*);
 typedef struct {
     voidFuncPtr fn;
     void* arg;
-    bool functional;
 } InterruptHandle_t;
 static InterruptHandle_t __pinInterruptHandlers[GPIO_PIN_COUNT] = {0,};
 
@@ -239,9 +238,7 @@ static void IRAM_ATTR __onPinInterrupt()
     }
 }
 
-extern void cleanupFunctional(void* arg);
-
-extern void __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtrArg userFunc, void * arg, int intr_type, bool functional)
+extern void __attachInterruptArg(uint8_t pin, voidFuncPtrArg userFunc, void* arg, int intr_type)
 {
     static bool interrupt_initialized = false;
 
@@ -250,14 +247,8 @@ extern void __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtrArg userFunc,
         esp_intr_alloc(ETS_GPIO_INTR_SOURCE, (int)ESP_INTR_FLAG_IRAM, __onPinInterrupt, NULL, &gpio_intr_handle);
     }
 
-    // if new attach without detach remove old info
-    if (__pinInterruptHandlers[pin].functional && __pinInterruptHandlers[pin].arg)
-    {
-    	cleanupFunctional(__pinInterruptHandlers[pin].arg);
-    }
     __pinInterruptHandlers[pin].fn = (voidFuncPtr)userFunc;
     __pinInterruptHandlers[pin].arg = arg;
-    __pinInterruptHandlers[pin].functional = functional;
 
     esp_intr_disable(gpio_intr_handle);
     if(esp_intr_get_cpu(gpio_intr_handle)) { //APP_CPU
@@ -269,25 +260,15 @@ extern void __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtrArg userFunc,
     esp_intr_enable(gpio_intr_handle);
 }
 
-extern void __attachInterruptArg(uint8_t pin, voidFuncPtrArg userFunc, void * arg, int intr_type)
-{
-	__attachInterruptFunctionalArg(pin, userFunc, arg, intr_type, false);
-}
-
 extern void __attachInterrupt(uint8_t pin, voidFuncPtr userFunc, int intr_type) {
-    __attachInterruptFunctionalArg(pin, (voidFuncPtrArg)userFunc, NULL, intr_type, false);
+    __attachInterruptArg(pin, (voidFuncPtrArg)userFunc, NULL, intr_type);
 }
 
 extern void __detachInterrupt(uint8_t pin)
 {
     esp_intr_disable(gpio_intr_handle);
-    if (__pinInterruptHandlers[pin].functional && __pinInterruptHandlers[pin].arg)
-    {
-    	cleanupFunctional(__pinInterruptHandlers[pin].arg);
-    }
     __pinInterruptHandlers[pin].fn = NULL;
     __pinInterruptHandlers[pin].arg = NULL;
-    __pinInterruptHandlers[pin].functional = false;
 
     GPIO.pin[pin].int_ena = 0;
     GPIO.pin[pin].int_type = 0;

cores/esp32/FunctionalInterrupt.cpp renamed to libraries/ESP32/examples/GPIO/FunctionalInterrupt/FunctionalInterrupt.cpp

@@ -6,7 +6,7 @@
  */
 
 #include "FunctionalInterrupt.h"
-#include "Arduino.h"
+#include <Arduino.h>
 
 typedef void (*voidFuncPtr)(void);
 typedef void (*voidFuncPtrArg)(void*);

cores/esp32/FunctionalInterrupt.h renamed to libraries/ESP32/examples/GPIO/FunctionalInterrupt/FunctionalInterrupt.h

@@ -1,5 +1,5 @@
 #include <Arduino.h>
-#include <FunctionalInterrupt.h>
+#include "FunctionalInterrupt.h"
 
 #define BUTTON1 16
 #define BUTTON2 17
@@ -29,16 +29,16 @@ public:
 
 private:
 	const uint8_t PIN;
-    volatile uint32_t numberKeyPresses;
-    volatile bool pressed;
+	volatile uint32_t numberKeyPresses;
+	volatile bool pressed;
 };
 
 Button button1(BUTTON1);
 Button button2(BUTTON2);
 
 
 void setup() {
-    Serial.begin(115200);
+	Serial.begin(115200);
 }
 
 void loop() {