Skip to content

Commit 8fec3cc

Browse files
MegaRedHandkariy
authored andcommitted
Compile ensure-no_std in CI for new lambdaworks backend (lambdaclass#1293)
* Ensure no-std for new lambdaworks backend * Fix: use correct matrix var name in job * Remove --release flag in ensure-no_std build * Update lambdaworks to fix-no-std commit * Update commit to main * Bump lambdaworks-math version * Update changelog
1 parent 87c82dc commit 8fec3cc

File tree

5 files changed

+63
-68
lines changed

5 files changed

+63
-68
lines changed

.github/workflows/rust.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,15 @@ jobs:
163163
- name: Check no-std
164164
run: |
165165
cd ensure-no_std
166-
cargo build --release
166+
cargo build --no-default-features
167+
cargo build
167168
168169
tests:
169170
needs: build-programs
170171
strategy:
171172
fail-fast: false
172173
matrix:
173-
special-features: ["", "lambdaworks-felt"]
174+
special_features: ["", "lambdaworks-felt"]
174175
target: [ test, test-no_std, test-wasm ]
175176
# TODO: features
176177
name: Run tests

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
#### Upcoming Changes
44

5+
* fix: bump *lambdaworks-math* to latest version, that fixes no-std support [#1293](https://github.com/lambdaclass/cairo-vm/pull/1293)
6+
57
* build: remove dependecy to `thiserror` (use `thiserror-no-std/std` instead)
68

79
* chore: use LambdaWorks' implementation of bit operations for `Felt252` [#1291](https://github.com/lambdaclass/cairo-rs/pull/1291)

Cargo.lock

Lines changed: 53 additions & 65 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ensure-no_std/Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ cairo-vm = { path = "../vm", default-features = false }
1111

1212
wee_alloc = "0.4.5"
1313

14+
[features]
15+
default = ["lambdaworks-felt"]
16+
lambdaworks-felt = ["cairo-felt/lambdaworks-felt"]
17+
1418

1519
[profile.dev]
1620
panic = "abort"

felt/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ lazy_static = { version = "1.4.0", default-features = false, features = [
1919
"spin_no_std",
2020
] }
2121
serde = { version = "1.0", features = ["derive"], default-features = false }
22-
lambdaworks-math = { version = "0.1.1", default-features = false, optional = true }
22+
lambdaworks-math = { version = "0.1.2", default-features = false, optional = true }
2323

2424
[dev-dependencies]
2525
proptest = "1.1.0"

0 commit comments

Comments
 (0)