Skip to content

Commit 796cbb1

Browse files
tdelabrokariy
authored andcommitted
use our own is_prime impl (lambdaclass#1238)
1 parent 591ad2b commit 796cbb1

File tree

11 files changed

+951
-194
lines changed

11 files changed

+951
-194
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,5 @@ bench/results
1414
cairo-rs-env/*
1515
cairo-rs-pypy-env/*
1616
cairo/
17+
18+
ensure-no_std/Cargo.lock

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929

3030
* move the vm in it's own directory and crate, different from the workspace
3131

32-
* add a `ensure_no_std` crate that will be used by the CI to check that new changes are not reverting `no_std` support
32+
* add a `ensure-no_std` crate that will be used by the CI to check that new changes are not reverting `no_std` support
33+
34+
* replace the use of `num-prime::is_prime` by a custom implementation, therefore restoring `no_std` compatibility
3335

3436
#### [0.5.1] - 2023-6-7
3537

Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[workspace]
22
members = ["cairo-vm-cli", "felt", "vm", "hint_accountant", "./deps/parse-hyperlinks"]
3-
exclude = ["ensure_no_std"]
3+
exclude = ["ensure-no_std"]
44

55
[workspace.dependencies]
66
mimalloc = { version = "0.1.29", default-features = false }
@@ -11,7 +11,6 @@ num-bigint = { version = "0.4", features = [
1111
rand = { version = "0.8.3", features = ["small_rng"], default-features = false }
1212
num-traits = { version = "0.2", default-features = false }
1313
num-integer = { version = "0.1.45", default-features = false }
14-
num-prime = { version = "0.4.3", features = ["big-int"], default-features = false }
1514
serde = { version = "1.0", features = ["derive"], default-features = false }
1615
serde_bytes = { version = "0.11.9", default-features = false, features = [
1716
"alloc",
File renamed without changes.

ensure_no_std/Cargo.toml renamed to ensure-no_std/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
[package]
2-
name = "ensure_no_std"
2+
name = "ensure-no_std"
33
version = "0.1.0"
44
edition = "2021"
55

66
[dependencies]
77
cairo-felt = { path = "../felt", default-features = false, features = ["alloc"] }
8+
cairo-vm = { path = "../vm", default-features = false }
89

910
wee_alloc = "0.4.5"
1011

ensure_no_std/src/main.rs renamed to ensure-no_std/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ pub extern "C" fn _start() -> ! {
1818
static ALLOC: wee_alloc::WeeAlloc = wee_alloc::WeeAlloc::INIT;
1919

2020
#[allow(unused_imports)]
21-
use cairo_felt;
21+
use {cairo_felt, cairo_vm};

ensure_no_std/Cargo.lock

Lines changed: 0 additions & 181 deletions
This file was deleted.

vm/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ num-bigint = {workspace = true}
3232
rand = {workspace = true}
3333
num-traits = {workspace = true}
3434
num-integer = {workspace = true}
35-
num-prime = {workspace = true}
3635
serde = {workspace = true}
3736
serde_bytes = {workspace = true}
3837
serde_json = {workspace = true}
@@ -71,6 +70,7 @@ ark-std = {workspace = true, optional = true}
7170
[dev-dependencies]
7271
assert_matches = "1.5.0"
7372
rstest = { version = "0.17.0", default-features = false }
73+
num-prime = { version = "0.4.3", features = ["big-int"]}
7474

7575
[target.'cfg(target_arch = "wasm32")'.dev-dependencies]
7676
wasm-bindgen-test = "0.3.34"

0 commit comments

Comments
 (0)