Make felt_from_number report errors properly (lambdaclass#1012)

instead of returning Ok(None) in case of an error

Co-authored-by: Mario Rugiero <[email protected]>
Co-authored-by: fmoletta <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 #### Upcoming Changes
 
+* fix: felt_from_number not properly returning parse errors [#1012](https://github.com/lambdaclass/cairo-rs/pull/1012)
 
 * fix: Fix felt sqrt and Signed impl [#1150](https://github.com/lambdaclass/cairo-rs/pull/1150)
 

src/serde/deserialize_program.rs

@@ -169,7 +169,10 @@ where
     D: Deserializer<'de>,
 {
     let n = Number::deserialize(deserializer)?;
-    Ok(Felt252::parse_bytes(n.to_string().as_bytes(), 10))
+    match Felt252::parse_bytes(n.to_string().as_bytes(), 10) {
+        Some(x) => Ok(Some(x)),
+        None => Err(String::from("felt_from_number parse error")).map_err(de::Error::custom),
+    }
 }
 
 #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)]
@@ -1386,4 +1389,16 @@ mod tests {
             "()"
         );
     }
+
+    #[test]
+    #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)]
+    fn deserialize_nonbase10_number_errors() {
+        let valid_json = r#"
+        {
+            "value" : 0x123
+        }"#;
+
+        let iden: Result<Identifier, serde_json::Error> = serde_json::from_str(valid_json);
+        assert!(iden.err().is_some());
+    }
 }