Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support jsdom as a Build Time Renderer #197

Closed
matt-gadd opened this issue Sep 13, 2019 · 1 comment
Closed

Support jsdom as a Build Time Renderer #197

matt-gadd opened this issue Sep 13, 2019 · 1 comment
Labels
enhancement next Issue/Pull Request for the next major version

Comments

@matt-gadd
Copy link
Contributor

Enhancement
Rendering many pages using Puppeteer can be very slow. We should consider trying jsdom to speed this up and offering it as an alternative or default renderer. To implement we might want to write a small api wrapper around jsdom that matches puppeteer to make the implementation tidier.
@matt-gadd matt-gadd added enhancement next Issue/Pull Request for the next major version labels Sep 13, 2019
@agubler agubler mentioned this issue Sep 13, 2019
Closed
@agubler
Copy link
Member

agubler commented Oct 29, 2019

Resolved by #211

@agubler agubler closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement next Issue/Pull Request for the next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agubler @matt-gadd