Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render error using body tag in tsx #809

Closed
robagar opened this issue Jul 8, 2020 · 0 comments · Fixed by #812
Closed

Render error using body tag in tsx #809

robagar opened this issue Jul 8, 2020 · 0 comments · Fixed by #812
Assignees
@agubler
Labels
area: core Core bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions

Comments

@robagar
Copy link

robagar commented Jul 8, 2020

Bug

Using the <body> tag in a .tsx file to attach nodes to the document body causes a render error in some circumstances

Package Version: @dojo/[email protected]

Code

See https://codesandbox.io/s/practical-field-g8on4?file=/src/main.tsx

Expected behavior:

No error, appropriate elements attached to document body.

Actual behavior:

Missing nodes, sibling elements in reverse order

Error in browser console:

vdom.ts:1780 Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
    at _runDomInstructionQueue (http://example.com/test_app/main.js:3131:35)
    at _runInvalidationQueue (http://example.com/test_app/main.js:3087:9)
    at http://example.com/test_app/main.js:3023:17
@robagar robagar changed the title Render error using <body> in tsx Render error using body tag in tsx Jul 8, 2020
@agubler agubler mentioned this issue Jul 10, 2020
Merged
3 tasks
@agubler agubler added area: core Core bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions labels Jul 10, 2020
@agubler agubler self-assigned this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubler agubler

Labels
area: core Core bug Something isn't working needs back-port The fix requires back porting to one or more previous major versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Rendering for multiple nested head and body nodes agubler/framework
2 participants
@robagar @agubler