Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registerDistinguishableCallback is called when widget has been destroyed causing an error. #543

Closed
maier49 opened this issue Sep 26, 2019 · 0 comments · Fixed by #547
Closed

registerDistinguishableCallback is called when widget has been destroyed causing an error. #543

maier49 opened this issue Sep 26, 2019 · 0 comments · Fixed by #547
Labels
area: core Core bug Something isn't working

Comments

@maier49
Copy link
Contributor

maier49 commented Sep 26, 2019

Bug

Sometimes when registerDistinguisableCallback is called, the widget has been destroyed so childNodes[index] is undefined when its owningId is accessed, causing an error. According to @agubler , this happens because it's called during the idle callback and will only affect dev. We can move it to the raf to avoid the issue.
Package Version: 6.0.3-pre

Expected behavior:
No error

Actual behavior:

Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Core bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run distinguishable in sync as only runs on dev mode agubler/framework
1 participant
@maier49