Falsy dnodes are now filtered by widgetbase, so deal with this in asserting render

Author: agubler

src/testing/support/assertRender.ts

@@ -30,12 +30,15 @@ export function formatDNodes(nodes: DNode | DNode[], depth: number = 0): string
 	for (let i = 0; i < depth; i++) {
 		tabs = `${tabs}\t`;
 	}
+	let requiresCarriageReturn = false;
 	let formattedNode = nodes.reduce((result: string, node, index) => {
-		if (node === null || node === undefined) {
+		if (!node) {
 			return result;
 		}
-		if (index > 0) {
+		if (requiresCarriageReturn) {
 			result = `${result}\n`;
+		} else {
+			requiresCarriageReturn = true;
 		}
 		result = `${result}${tabs}`;
 
@@ -48,7 +51,7 @@ export function formatDNodes(nodes: DNode | DNode[], depth: number = 0): string
 		}
 
 		result = `${result}${formatNode(node, tabs)}`;
-		if (node.children && node.children.length > 0) {
+		if (node.children && node.children.some((child) => !!child)) {
 			result = `${result}, [\n${formatDNodes(node.children, depth + 1)}\n${tabs}]`;
 		}
 		return `${result})`;

tests/testing/unit/support/assertRender.ts

@@ -15,7 +15,13 @@ class MockWidget extends WidgetBase {
 
 class OtherWidget extends WidgetBase {
 	render() {
-		return v('div', { key: 'one', classes: 'class' }, ['text node', undefined, w(MockWidget, {})]);
+		return v('div', { key: 'one', classes: 'class' }, ['text node', undefined, '', null, w(MockWidget, {})]);
+	}
+}
+
+class FalsyChildren extends WidgetBase {
+	render() {
+		return v('div', { key: 'one', classes: 'class' }, [undefined, '', null]);
 	}
 }
 
@@ -86,11 +92,19 @@ describe('support/assertRender', () => {
 		assert.doesNotThrow(() => {
 			assertRender(
 				renderResult,
-				v('div', { classes: 'class', key: 'one' }, ['text node', undefined, w(MockWidget, {})])
+				v('div', { classes: 'class', key: 'one' }, ['text node', undefined, '', null, w(MockWidget, {})])
 			);
 		});
 	});
 
+	it('Should not throw when all the children are falsy', () => {
+		const widget = new FalsyChildren();
+		const renderResult = widget.__render__();
+		assert.doesNotThrow(() => {
+			assertRender(renderResult, v('div', { classes: 'class', key: 'one' }, [undefined, '', null]));
+		});
+	});
+
 	it('Should throw when actual and expected do not match', () => {
 		const widget = new OtherWidget();
 		const renderResult = widget.__render__();