Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Webpack 2 #67

Merged
merged 4 commits into from
Feb 16, 2017
Merged

Webpack 2 #67

merged 4 commits into from
Feb 16, 2017

Conversation

bryanforbes
Copy link
Member

Type: enhancement

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Updates cli-build to use Webpack 2

@bryanforbes
Copy link
Member Author

I should note that I have updated the source-map-loader dependency to my fork and submitted a pull request to the main project.

@codecov-io
Copy link

Codecov Report

Merging #67 into master will decrease coverage by -0.36%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   96.29%   95.94%   -0.36%     
==========================================
  Files           7        7              
  Lines         270      271       +1     
  Branches       45       45              
==========================================
  Hits          260      260              
  Misses          8        8              
- Partials        2        3       +1
Impacted Files Coverage Δ
src/plugins/I18nPlugin.ts 100% <100%> (ø)
src/plugins/CoreLoadPlugin.ts 100% <100%> (ø)
src/plugins/InjectModulesPlugin.ts 98.95% <66.66%> (-1.05%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbfd2d...5c6b34b. Read the comment docs.

Copy link
Member

@agubler agubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm, is there an open issue for the source-map-loader?

@agubler agubler merged commit 4f217b5 into dojo:master Feb 16, 2017
rishson added a commit to rishson/cli-build that referenced this pull request Mar 1, 2017
* upstream/master: (27 commits)
  Webpack typings (dojo#69)
  fix loader resolution to allow linking (dojo#75)
  up to 2.2.1 (dojo#74)
  CSS-Module Dts preloader for TS and CSS files (dojo#72)
  Configuration to work with lazy widgets, examples-183 (dojo#70)
  Update package metadata
  2.0.0-alpha.13
  Update package metadata
  2.0.0-alpha.12
  Webpack 2 (dojo#67)
  Update package metadata
  2.0.0-alpha.11
  Fix help so it displays per grouping (dojo#65)
  Update package metadata
  2.0.0-alpha.10
  Add file loader for image files (dojo#64)
  Adding options to build components (dojo#61)
  Use module replacement to allow widgets to import with `.css` extension (dojo#62)
  Add path and classes to css-modules json to assist a theme hierarchy (dojo#57)
  update source maps config for @dojo namespace (dojo#56)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants