-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds fail with web3 #457
Comments
I dug into this a bit to find that's it related to the web3 package requiring these
you can see this by adding the following to the top of a new app
|
this looks like it's a result of - https://github.com/webpack/changelog-v5/blob/master/README.md#automatic-nodejs-polyfills-removed by hacking @dojo/cli-build-app/config/dev.config.js and adding at line 107. the line above
i was able to get my app to load. |
I'd like to suggestion this change to
so one could then add this to their
my first stab (i couldn't get the linter to not complain about using reduce) a62b866 why?
|
Bug / Enhancement
I was trying to use
web3
in a Dojo app, but I get some odd errors.With a vanilla
dojo create app --name dojo-web3 --tsx
, it will build but throws a runtime error. If I delete thepackage-lock.json
andnode_modules
, I get a build time error.Package Version: 7.0 & 7.0.5
Code
sample repo
Expected behavior:
I would expect a build without errors and a workflow to build a Dapp with Dojo.
Actual behavior:
Node Version: 14.16.0
NPM Version: 6.17.11
The text was updated successfully, but these errors were encountered: