You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Had some ideas for potential improvements for the development build output. Also I should say, I'm of the mindset of keeping terminal output from developer tooling very minimal. It's something ava does well.
Here's a screenshot from my terminal output, with one linting error:
If for example I omit a semi colon from a line of JavaScript, I see:
✖ errors: 2
⚠ warnings: 0
errors:
./src/main.ts
Module build failed: Error: Compilation failed due to tslint errors.
at report (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:93:11)
at lint (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:74:3)
at Object.module.exports (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:140:3)
@ multi ./src/main.css ./src/main.ts,./src/main.ts
[15, 32]: Missing semicolon
@ multi ./src/main.css ./src/main.ts
Errors shows '2' but there is only one.
If warnings is '0' I don't see any need in showing that label
Module build failed: Error: Compilation failed due to tslint errors. I don't think a linter should prevent the build, since I feel it's normal during development to not adhere to linting rules, but still want to see the webpage in your browser. Maybe the build could fail, but can still build the assets so it can be viewed?
errors:
./src/main.ts
Module build failed: Error: Compilation failed due to tslint errors.
I feel this output can be kept minimal, for example, could that whole section be replaced with:
Compilation failed due to tslint errors.
The stack trace is quite distracting (long line length, and red):
at report (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:93:11)
at lint (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:74:3)
at Object.module.exports (/Users/umarhansa/development/dojo-devtool-todomvc/app/node_modules/tslint-loader/index.js:140:3)
Maybe we could hide it?
The main tslint issue:
@ multi ./src/main.css ./src/main.ts,./src/main.ts
[15, 32]: Missing semicolon
@ multi ./src/main.css ./src/main.ts
I feel the '@' symbols are redundant, don't think the word 'multi' needs to be there? And it's confusing to figure out what file contains the error!
Not sure it's necessary to see all of this info? For example seeing manifest.json (0.38kb) / (0.16kb gz) is not useful? Same with source map files. Maybe a verbose flag for all that info is better?
I very much agree with everything stated here. I also wanted to mention that the output at: file:///Users... location is incorrect. I do not see it on my file system and cd'ing to the folder says it does not exist. Is it because the 4 //// is invalid and it should only be 2? Either way it's wrong.
Looking at this issue believe the following can be updated
Log all errors not just last one
Hide warnings message if no warnings exist
Hide some output details behind verbose flag
I feel the build should fail if there are errors in the typing, this prevents more errors from slipping in the code. The stack trace, while long, can give helpful hints sometimes in detecting the error.
@agubler would you know the significance of multi in the @ multi log?
Had some ideas for potential improvements for the development build output. Also I should say, I'm of the mindset of keeping terminal output from developer tooling very minimal. It's something ava does well.
Here's a screenshot from my terminal output, with one linting error:
If for example I omit a semi colon from a line of JavaScript, I see:
Module build failed: Error: Compilation failed due to tslint errors.
I don't think a linter should prevent the build, since I feel it's normal during development to not adhere to linting rules, but still want to see the webpage in your browser. Maybe the build could fail, but can still build the assets so it can be viewed?I feel this output can be kept minimal, for example, could that whole section be replaced with:
Maybe we could hide it?
I feel the '@' symbols are redundant, don't think the word 'multi' needs to be there? And it's confusing to figure out what file contains the error!
Not sure it's necessary to see all of this info? For example seeing
manifest.json (0.38kb) / (0.16kb gz)
is not useful? Same with source map files. Maybe a verbose flag for all that info is better?Not sure the hash is useful to see?
The text was updated successfully, but these errors were encountered: