Remove SAML metadata monkeypatches #3396
Labels
chore
Repository/build/dependency maintenance
low priority
Thing we want to see implemented at some point
student
Things summer interns can do
Belnet requires that specific fields are present in the SAML metadata. The gem we used didn't support this so we monkeypatched the code that generated the metadata to add these fields:
In a recent version, ruby saml added support for custom metadata fields. This means that the monkeypatch can probably be removed.
More specifically, I think
lib/SAML/metadata.rb
can be removed (after inspecting the edit history to check if other changes weren't made). The fields that are added in line 128 till 166 should be moved to separate class as is shown in SAML-Toolkits/ruby-saml#602The change should be validated by comparing the generated metadata at
/users/saml/metadata
before and after the fix, and by signing in into ugent from naos.The text was updated successfully, but these errors were encountered: