fix(docz-utils): fix closing tag detection in removeTags
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
removeTags behaviorremoveTags
nicolo-ribaudo
force-pushed
the
fix-top-level-jsx-tag-removal
branch
from
2f56d4a
to
ab16818
Compare
JLHwung
approved these changes
Jan 31, 2022
adbayb
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Thank you @nicolo-ribaudo .
It seems to work properly 🎉 (tested in my project via patch-package).
renatobenks
reviewed
Feb 3, 2022
|
Great job at this @nicolo-ribaudo 🎉 Also, thanks for testing it @adbayb, we appreciate it! |
|
Thanks for this update! |
renatobenks
approved these changes
Feb 7, 2022
|
@Elgeneinar I'm scheduling the release to be done between today and tomorrow, but I'll try to let everyone knows in all following corresponded PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrote the description of this fix and the reason behind it at #1691 (comment).
I fixed it in different commits:
test(docz-utils): add test for current removeTags behaviorshows the old behavior (one test was correct, the other one was already broken)chore(docz-utils): update @babel/* dependenciesupdates@babel/traverseand the other babel packages, to force the version containing the fix for the bug docz was relying ontest(docz-utils): update removeTags (broken) snapshotsupdates the tests to show the new broken behaviorfix(docz-utils): fix closing tag detection in removeTagsfixes both the broken testsFixes #1691