Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a showMarkdownEditButton flag to themeConfig #1291

Closed
rakannimer opened this issue Nov 29, 2019 · 0 comments
Closed

Add a showMarkdownEditButton flag to themeConfig #1291

rakannimer opened this issue Nov 29, 2019 · 0 comments
Labels
feature request v2

Comments

@rakannimer
Copy link
Contributor

In the header https://github.com/doczjs/docz/blob/master/core/gatsby-theme-docz/src/components/Header/index.js#L15 the code assumes that Entry has an edit boolean field and defaults it to true.

However, entry doesn't have an edit flag.

2 suggestions :

  1. Add themeConfig.showMarkdownEditButton to docz config and default it to true.
  2. Add edit to Entry and read it from the header of the current mdx file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rakannimer