Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: uppercase SQL keywords #32

Open
greg0ire opened this issue Apr 11, 2020 · 4 comments
Open

Feature request: uppercase SQL keywords #32

greg0ire opened this issue Apr 11, 2020 · 4 comments

Comments

@greg0ire
Copy link
Member

greg0ire commented Apr 11, 2020

See jdorn/sql-formatter#97 and jdorn/sql-formatter#84

@ftrotter
Copy link

Thanks for transferring this over!! I am still interested. Generally, I think this should be a configuration signal and there should be the following options:

  • Do not change the case in the original SQL at all.
  • Change all SQL keywords to upper-case
  • Change all SQL keywords and SQL functions to upper-case

Thanks for looking into it!!

@greg0ire
Copy link
Member Author

should be a configuration signal

I think we should change the constructor of SqlFormatter, but I'm not sure how… maybe pass an options array? @goetas what would you recommend for this?

@rodnaph
Copy link

rodnaph commented Aug 19, 2021

@greg0ire Linked PR has a patch for this, any chance of a review? I'd like to use this, thanks.

@greg0ire
Copy link
Member Author

@rodnaph didn't spot it in my notifications, but sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants