From 926faee684f9837664164873f3099a6140ba913b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Fri, 7 Jan 2022 20:03:31 +0100 Subject: [PATCH] Remove ignore rules for issues fixed upstream The rules still should apply when using DBAL v2 --- phpstan-baseline.neon | 10 ---------- phpstan-dbal2.neon | 12 ++++++++++++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 46fb4d40cb5..c10d97a9431 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -1335,16 +1335,6 @@ parameters: count: 1 path: lib/Doctrine/ORM/Query/AST/Functions/LowerFunction.php - - - message: "#^Parameter \\#2 \\$start of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int, string given\\.$#" - count: 1 - path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php - - - - message: "#^Parameter \\#3 \\$length of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int\\|null, string\\|null given\\.$#" - count: 1 - path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php - - message: "#^Parameter \\#1 \\$simpleArithmeticExpr of method Doctrine\\\\ORM\\\\Query\\\\SqlWalker\\:\\:walkSimpleArithmeticExpression\\(\\) expects Doctrine\\\\ORM\\\\Query\\\\AST\\\\SimpleArithmeticExpression, Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node given\\.$#" count: 1 diff --git a/phpstan-dbal2.neon b/phpstan-dbal2.neon index 6bf77b8c6d7..88ec58248b4 100644 --- a/phpstan-dbal2.neon +++ b/phpstan-dbal2.neon @@ -25,3 +25,15 @@ parameters: message: '/^Call to an undefined method Doctrine\\Common\\Cache\\Cache::deleteAll\(\)\.$/' count: 1 path: lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php + + + # Won't get fixed in DBAL 2 + - + message: "#^Parameter \\#2 \\$start of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int, string given\\.$#" + count: 1 + path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php + + - + message: "#^Parameter \\#3 \\$length of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int\\|null, string\\|null given\\.$#" + count: 1 + path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php