-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Proper classes for QueryBuilder SQL parts #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Originally, I wanted to start only with the By implementing one aspect, we'll settle on most of the questions and then implement the rest. Otherwise, we may end up discussing and changing the same things three times for each of the newly introduced classes. |
|
@morozov I don't feel like this makes it much easier. They all take their roots in |
|
But you may be right. I'll see if I can make a very small PR with just |
|
I'm not concerned about the scale of the change. You and I have a history of discovering huge amounts of work by starting with mid-scale changes. We can go full scale if you prefer, but I want to make sure you're not disappointed by the number of back and forths and the time it may take to get done. |
|
As long as we're getting there, I don't really mind. But you may have a point, we could possibly get there in less time by going with small increments. Let me try a very small PR for the join only, and we'll see much more clearly which path we want to follow. |
|
Superseded by #3836. |
Summary
As suggested by @morozov in #3824 (comment):
This PR introduces 3 classes, which replace the
$sqlPartsnested associative array:QueryPartsQueryPartFromQueryPartJoinThis is a first draft with both phpunit & phpstan happy.
A few pain points are to be discussed, though.