Enable PHPStan in tests

composer.json

@@ -21,6 +21,7 @@
         "doctrine/coding-standard": "^4.0",
         "jetbrains/phpstorm-stubs": "^2018.1.2",
         "phpstan/phpstan": "^0.10.1",
+        "phpstan/phpstan-phpunit": "^0.10.0",
         "phpunit/phpunit": "^7.1.2",
         "phpunit/phpunit-mock-objects": "!=3.2.4,!=3.2.5",
         "symfony/console": "^2.0.5|^3.0|^4.0",

phpstan.neon.dist

@@ -1,7 +1,11 @@
+includes:
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+
 parameters:
     level: 3
     paths:
         - %currentWorkingDirectory%/lib
+        - %currentWorkingDirectory%/tests
     autoload_files:
         - %currentWorkingDirectory%/tests/phpstan-polyfill.php
     reportUnmatchedIgnoredErrors: false
@@ -44,3 +48,10 @@ parameters:
 
         # weird class name, doesn't exist in stubs either
         - '~unknown class OCI-(Lob|Collection)~'
+
+        # magic stuff
+        - '~^Access to property \$\w+ on an unknown class Doctrine\\MyFetchClass\.\z~'
+
+    excludes_analyse:
+        # legacy remnants from doctrine/common
+        - tests/Doctrine/Tests/Mocks/TaskMock.php

tests/Doctrine/Tests/DBAL/Cache/QueryCacheProfileTest.php

@@ -12,29 +12,19 @@ class QueryCacheProfileTest extends DbalTestCase
     private const LIFETIME  = 3600;
     private const CACHE_KEY = 'user_specified_cache_key';
 
-    /**
-     * @var QueryCacheProfile
-     */
+    /** @var QueryCacheProfile */
     private $queryCacheProfile;
 
-    /**
-     * @var string
-     */
+    /** @var string */
     private $query = 'SELECT * FROM foo WHERE bar = ?';
 
-    /**
-     * @var int[]
-     */
+    /** @var int[] */
     private $params = [666];
 
-    /**
-     * @var string[]
-     */
+    /** @var int[] */
     private $types = [ParameterType::INTEGER];
 
-    /**
-     * @var string[]
-     */
+    /** @var string[] */
     private $connectionParams = [
             'dbname'   => 'database_name',
             'user'     => 'database_user',