Deprecate Doctrine\DBAL\Types\Type::getDefaultLength()

Majkl578 · Majkl578 · commit c38bbcc09cd9 · 2018-08-18T21:33:15.000+02:00
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,9 @@
 # Upgrade to 2.9
 
+## Deprecated `Doctrine\DBAL\Types\Type::getDefaultLength()`
+
+This method was never used by DBAL internally. It is now deprecated and will be removed in DBAL 3.0.
+
 ## Deprecated `Doctrine\DBAL\Types\Type::__toString()`
 
 Relying on string representation is discouraged and will be removed in DBAL 3.0.
diff --git a/lib/Doctrine/DBAL/Types/Type.php b/lib/Doctrine/DBAL/Types/Type.php
@@ -146,7 +146,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
      *
      * @return int|null
      *
-     * @todo Needed?
+     * @deprecated Rely on information provided by the platform instead.
      */
     public function getDefaultLength(AbstractPlatform $platform)
     {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform)`
`146`	`146`	`*`
`147`	`147`	`* @return int\|null`
`148`	`148`	`*`
`149`		`- * @todo Needed?`
	`149`	`+ * @deprecated Rely on information provided by the platform instead.`
`150`	`150`	`*/`
`151`	`151`	`public function getDefaultLength(AbstractPlatform $platform)`
`152`	`152`	`{`