You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've run into a situation where I'm using ArrayCollection to filter some objects using Criteria::orderBy().
Assume these objects have a private property 'foo', and a public method 'foo()' which returns the private property value. The ClosureExpressionVisitor will check for various public methods existence (for example is*/get* variants, or access through magic methods like __get/__call).
I have the feeling there is one more check missing here, which is checking if a public method exists that matches the field name literally (without prepending get/is or through magic methods).
I'm not sure if this was omitted with a reason, maybe this means we are using a convention thats not very widespread? I will create a PR to hopefully communicate my issue better.
The text was updated successfully, but these errors were encountered:
I've run into a situation where I'm using ArrayCollection to filter some objects using Criteria::orderBy().
Assume these objects have a private property 'foo', and a public method 'foo()' which returns the private property value. The ClosureExpressionVisitor will check for various public methods existence (for example is*/get* variants, or access through magic methods like __get/__call).
I have the feeling there is one more check missing here, which is checking if a public method exists that matches the field name literally (without prepending get/is or through magic methods).
I'm not sure if this was omitted with a reason, maybe this means we are using a convention thats not very widespread? I will create a PR to hopefully communicate my issue better.
The text was updated successfully, but these errors were encountered: