-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queries containing binary parts causes twig to crash in profiler due to UFT-8 errors #1315
Comments
Ok and you believe this is a bug in doctrine-bundle how? |
Because doctrine-bundle is using this filter? So I would suspect either the data we are passing it isn't encoded properly or we need to provide a specific encoding for it. |
@nicolas-grekas could you check this please? |
Can you please create a small reproducing app @jdelaune? Usually, VarDumper handles that, but apparently not every time. That'd help investigate the issue. Thanks in advance. |
Sorry had a busy week, here is an example project reproducing the issue: https://github.com/jdelaune/ulid-profiler-bug Narrowed it down to the Doctrine SQL Filter causing the issue. |
But that example fails for me even before reaching doctrine profiler
And I observe same when I downgraded example to doctrine-bundle 2.2.* |
I'm running MySQL looks like you are on PostgreSQL?
|
I've used postgres because that's what you've set in your reproducer https://github.com/jdelaune/ulid-profiler-bug/blob/4c80e8a5da90e0d0cc489ca05f1101487da4d27a/.env#L27 Yep, I can confirm your issue with MySQL |
Ah sorry, I just left whatever Symfony autogenerated and was using a |
Moving to doctrine/sql-formatter#91 |
When inspecting some queries where we have a where filter using binary data because the column is a ULID binary column we run into twig errors in the profiler.
Uncaught PHP Exception Twig\Error\RuntimeError: "The string to escape is not a valid UTF-8 string." at /vendor/doctrine/doctrine-bundle/Resources/views/Collector/db.html.twig line 219
and
Uncaught PHP Exception Twig\Error\RuntimeError: "The string to escape is not a valid UTF-8 string." at /vendor/doctrine/doctrine-bundle/Resources/views/Collector/db.html.twig line 226
Seems to be the
|e('html_attr')
twig filter causing the issue (If I change the filter to|e('html')
it seems to resolve the error).Database is utf8mb4 encoded. Not sure if that makes any difference.
The text was updated successfully, but these errors were encountered: