controlapi: Allow multiple randomly assigned published ports on service #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Oct 18, 2016
| @@ -165,6 +165,10 @@ func validateEndpointSpec(epSpec *api.EndpointSpec) error { | |||
|
|
|||
| portSet := make(map[portSpec]struct{}) | |||
| for _, port := range epSpec.Ports { | |||
| if port.PublishedPort == 0 { | |||
There was a problem hiding this comment.
Does this need a comment? (e.g., if no host port is assigned, ports can never conflict)
There was a problem hiding this comment.
Added a comment.
|
Thanks @aaronlehmann, makes sense that this is the issue (I was thinking way to complicated 😄) |
Current coverage is 56.77% (diff: 100%)@@ master #1657 diff @@
==========================================
Files 90 90
Lines 14574 14567 -7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8280 8270 -10
- Misses 5207 5213 +6
+ Partials 1087 1084 -3
|
This fixes a 1.12.2 regression. Signed-off-by: Aaron Lehmann <[email protected]>
aaronlehmann
force-pushed
the
published-port
branch
from
33c3a1a
to
5d1faa8
Compare
aluzzardi
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 1.12.2 regression.
See moby/moby#27469
cc @thaJeztah @allencloud