Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlapi: Allow duplicate published ports when they use different protocols #1632

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

aaronlehmann
Copy link
Collaborator

Fix controlapi to allow duplicate published ports as long as different
protocols are in use. This is a 1.12.2 regression.

…rotocols

Fix controlapi to allow duplicate published ports as long as different
protocols are in use. This is a 1.12.2 regression.

Signed-off-by: Aaron Lehmann <[email protected]>
Copy link
Contributor

@mrjana mrjana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Current coverage is 55.12% (diff: 100%)

Merging #1632 into master will decrease coverage by 0.22%

@@             master      #1632   diff @@
==========================================
  Files            91         91          
  Lines         15030      15034     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           8320       8288    -32   
- Misses         5625       5653    +28   
- Partials       1085       1093     +8   

Sunburst

Powered by Codecov. Last update a8e2bb9...db8be0b

@LK4D4
Copy link
Contributor

LK4D4 commented Oct 13, 2016

LGTM

1 similar comment
@dongluochen
Copy link
Contributor

LGTM

@yank1
Copy link

yank1 commented Oct 26, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants